Testsuite for polar#123
Merged
Merged
Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
kshyatt
force-pushed
the
testsuite-polar
branch
from
December 22, 2025 17:34
650e274 to
1ba0502
Compare
kshyatt
force-pushed
the
testsuite-polar
branch
2 times, most recently
from
December 22, 2025 18:03
ecfd5ab to
f4d7da1
Compare
kshyatt
force-pushed
the
testsuite-polar
branch
from
December 22, 2025 18:19
f4d7da1 to
f91f42a
Compare
kshyatt
force-pushed
the
testsuite-polar
branch
from
December 22, 2025 19:23
c0c3126 to
00c578c
Compare
Jutho
reviewed
Dec 22, 2025
| Q, R = qr_compact!(A) | ||
| Rc = view(A, 1:n, 1:n) | ||
| copy!(Rc, R) | ||
| Rc .= R |
Member
There was a problem hiding this comment.
is copy! still problematic on GPU?
Member
Author
There was a problem hiding this comment.
Copying to a SubArray is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the
polartests in toTestSuite. Also improved some error messages, and fixed what I think is a badif/elseinLQandQR.The
polartests were already covering all supported algos so I didn't create a separate set of tests for those.