Use TestSuite for projections tests - #125
Merged
Merged
Conversation
kshyatt
force-pushed
the
testsuite-projections
branch
from
December 22, 2025 20:13
4b17bbc to
33b61d4
Compare
Jutho
reviewed
Dec 22, 2025
Jutho
approved these changes
Dec 22, 2025
kshyatt
force-pushed
the
testsuite-projections
branch
from
December 23, 2025 06:21
33b61d4 to
e5b3073
Compare
kshyatt
enabled auto-merge (squash)
December 23, 2025 06:55
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Jutho
reviewed
Dec 23, 2025
| # test approximate error calculation | ||
| A = normalize!(A) | ||
| normA = norm(A) | ||
| A ./= normA |
Member
There was a problem hiding this comment.
Is normalize! another GPU problem?
Member
Author
There was a problem hiding this comment.
I'll try to add support for it to GPUArrays.jl
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it says on the tin. Use
TestSuitefor the projections tests and additionally test them with some new element types!