Skip to content

Use TestSuite for eigh#131

Merged
kshyatt merged 7 commits into
mainfrom
testsuite-eigh
Dec 27, 2025
Merged

Use TestSuite for eigh#131
kshyatt merged 7 commits into
mainfrom
testsuite-eigh

Conversation

@kshyatt

@kshyatt kshyatt commented Dec 23, 2025

Copy link
Copy Markdown
Member

No description provided.

@kshyatt
kshyatt requested review from Jutho and lkdvos December 23, 2025 13:34
@codecov

codecov Bot commented Dec 23, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about the === and copy!

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments about maybe using project_hermitian in some of the tests, doesn't make too much of a difference but if nothing else it covers the package functions slightly better. Otherwise good to go for me

Comment thread test/testsuite/eigh.jl Outdated
Comment thread test/testsuite/eigh.jl Outdated
Comment thread test/testsuite/eigh.jl Outdated
@kshyatt

kshyatt commented Dec 27, 2025

Copy link
Copy Markdown
Member Author

Think I got everything...

@kshyatt
kshyatt enabled auto-merge (squash) December 27, 2025 10:47
@kshyatt
kshyatt merged commit 0c86324 into main Dec 27, 2025
10 checks passed
@kshyatt
kshyatt deleted the testsuite-eigh branch December 27, 2025 12:15
@lkdvos lkdvos mentioned this pull request Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants