Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Jan 27, 2026
lkdvos
reviewed
Jan 27, 2026
lkdvos
reviewed
Jan 27, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
I think the Mooncake changes look great, but I don't like the JET changes. Can we report an issue to JET for this, and just leave the rest as-is for now?
Member
Author
|
The problem is our codequality tests will fail, unless you want me to add the disabler comments in these spots? |
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
lkdvos
reviewed
Jan 28, 2026
Member
|
Linking this issue here: aviatesk/JET.jl#801 |
Member
Author
|
Let's see if we can just bump Mooncake only |
lkdvos
approved these changes
Jan 29, 2026
kshyatt
enabled auto-merge (squash)
January 29, 2026 13:47
lkdvos
disabled auto-merge
January 29, 2026 14:56
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.