Make Format check safe for fork PRs (pull_request trigger)#260
Merged
Conversation
Switch the trigger from pull_request_target to pull_request and drop the write permissions. GitHub now refuses to check out fork PR code from a pull_request_target workflow, breaking formatting checks for external contributors. See QuantumKitHub/.github#2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the Format workflow trigger from
pull_request_targettopull_requestand drops theactions: write/pull-requests: writepermissions.
GitHub now refuses to check out fork PR code from a
pull_request_targetworkflow, which broke the formatting check for all external contributors
(PRs from forks). The reusable workflow has been reworked to run safely under a
read-only
pull_requestcontext and reports the formatting diff in the jobsummary instead of commenting on the PR.
Depends on QuantumKitHub/QuantumKitHubActions#2 (the reusable workflow update),
which should be merged first since this references
FormatCheck.yml@main.Refs QuantumKitHub/.github#2
🤖 Generated with Claude Code