Skip to content

Support new projections on GPU#81

Merged
kshyatt merged 2 commits into
mainfrom
ksh/proj
Oct 16, 2025
Merged

Support new projections on GPU#81
kshyatt merged 2 commits into
mainfrom
ksh/proj

Conversation

@kshyatt

@kshyatt kshyatt commented Oct 15, 2025

Copy link
Copy Markdown
Member

No description provided.

@kshyatt
kshyatt requested a review from lkdvos October 15, 2025 22:16
@github-actions

github-actions Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Your PR no longer requires formatting changes. Thank you for your contribution!

@kshyatt kshyatt mentioned this pull request Oct 15, 2025
Merged
@kshyatt
kshyatt enabled auto-merge (squash) October 15, 2025 23:00
@codecov

codecov Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl 60.00% 8 Missing ⚠️
...MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl 60.00% 8 Missing ⚠️
Files with missing lines Coverage Δ
...ixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl 65.85% <60.00%> (-5.58%) ⬇️
...MatrixAlgebraKitCUDAExt/MatrixAlgebraKitCUDAExt.jl 68.18% <60.00%> (-6.82%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lkdvos
lkdvos approved these changes Oct 16, 2025
View reviewed changes

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, if we merge the hermitian checks PR can immediately depend on this.

@kshyatt

kshyatt commented Oct 16, 2025

Copy link
Copy Markdown
Member Author

The coverage issue should resolve once we have the polar PR running on top of this

@Jutho

Jutho commented Oct 16, 2025

Copy link
Copy Markdown
Member

I assume the kernels cannot use the type parameter value anti at compile time, and this is why you have to write out the kernels separately for both cases? Certainly looks good to me.

@kshyatt

kshyatt commented Oct 16, 2025

Copy link
Copy Markdown
Member Author

I was getting unhappiness from GPUCompiler when I tried that last, but hopefully we can try it again in the future -- I would ideally like to refactor these into a common KernelAbstractions kernel to avoid all the duplication.

@kshyatt
kshyatt merged commit 17ea798 into main Oct 16, 2025
9 of 10 checks passed
@kshyatt
kshyatt deleted the ksh/proj branch October 16, 2025 10:27
@lkdvos lkdvos mentioned this pull request Nov 14, 2025
Merged
lkdvos referenced this pull request Nov 14, 2025
@lkdvos
Release v0.6 + small fixes (#97)
eceef30 
* Bump v0.6

* rename `gaugefix` -> `fixgauge`

* reduce unnecessary warnings

* fix `copy_input` signatures in Mooncake tests

* Add changelog to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkdvos lkdvos lkdvos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kshyatt @Jutho @lkdvos