Change default fixed-point gradient algorithm to :eigsolver#246
Merged
Conversation
leburgel
marked this pull request as draft
August 21, 2025 13:03
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
leburgel
changed the title
:eigsolver:eigsolver
leburgel
marked this pull request as ready for review
August 22, 2025 09:36
lkdvos
reviewed
Aug 22, 2025
Comment on lines
+396
to
+400
| backup_ls_alg = GMRES(; tol = alg.solver_alg.tol, maxiter = alg.solver_alg.maxiter, verbosity = alg.solver_alg.verbosity) | ||
| y, info = reallinsolve(∂f∂x, ∂F∂x, x₀, backup_ls_alg, 1, -1) | ||
| if alg.solver_alg.verbosity > 0 && info.converged != 1 | ||
| @warn("backup gradient fixed-point iteration reached maximal number of iterations:", info) | ||
| end |
Member
There was a problem hiding this comment.
How do you feel about making a backup alg which is LinSolver, and just returning fpgrad(args..., alg::LinSolver)? It removes a tiny bit of code, but it might also be slightly more readable.
pbrehmer
reviewed
Aug 22, 2025
Co-authored-by: Paul Brehmer <paul.brehmer@univie.ac.at>
lkdvos
approved these changes
Aug 26, 2025
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
looks good for me once tests pass
leburgel
enabled auto-merge (squash)
August 26, 2025 10:25
lkdvos
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the default fixed-point gradient algorithm to
:eigsolver, and adds a fallback linsolve in case the eigsolver approach fails.