Skip to content

Excise RecursiveVec - #95

Merged
lkdvos merged 1 commit into
masterfrom
ld-mpskit
Nov 15, 2024
Merged

Excise RecursiveVec#95
lkdvos merged 1 commit into
masterfrom
ld-mpskit

Conversation

@lkdvos

@lkdvos lkdvos commented Nov 14, 2024

Copy link
Copy Markdown
Member

This PR removes references to RecursiveVec to fix compatibility with the new KrylovKit.jl

@codecov

codecov Bot commented Nov 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/operators/derivatives.jl 41.93% <100.00%> (ø)

... and 1 file with indirect coverage changes

@lkdvos
lkdvos enabled auto-merge (squash) November 14, 2024 20:09
@lkdvos
lkdvos requested a review from pbrehmer November 14, 2024 20:09
@lkdvos
lkdvos merged commit f508663 into master Nov 15, 2024
@pbrehmer
pbrehmer deleted the ld-mpskit branch November 15, 2024 08:39
@lkdvos

lkdvos commented Nov 15, 2024

Copy link
Copy Markdown
Member Author

@pbrehmer should we already tag a version, such that at least pepskit compiles again?

@pbrehmer

Copy link
Copy Markdown
Collaborator

Yes let's do that - I think we anyway have all the features that we wanted to implement for v0.3 if I remember the road map correctly :)

@lkdvos

lkdvos commented Nov 15, 2024

Copy link
Copy Markdown
Member Author

Should I try and get the sequential thing reviewed first too?

@pbrehmer

Copy link
Copy Markdown
Collaborator

You can probably tag already since I don't have the time to work on that PR this week anymore. Also, it is mostly relevant for #91 I think, and that will take a bit to get merged anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants