Skip to content

Fix TruncationIntersection implementation and test - #300

Merged
lkdvos merged 2 commits into
mainfrom
ld-trunc
Oct 15, 2025
Merged

Fix TruncationIntersection implementation and test#300
lkdvos merged 2 commits into
mainfrom
ld-trunc

Conversation

@lkdvos

@lkdvos lkdvos commented Oct 10, 2025

Copy link
Copy Markdown
Member

Somehow another bug that slipped through the holes of the maze...

@codecov

codecov Bot commented Oct 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/factorizations/truncation.jl 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/factorizations/truncation.jl 75.73% <66.66%> (+2.20%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
lkdvos requested a review from Jutho October 10, 2025 14:40

@Jutho Jutho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you also want this to be recursive; I am fine either way.

@lkdvos

lkdvos commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

I'll merge for now, and revisit if we actually run into type instabilities.

@lkdvos
lkdvos merged commit b9d6d2c into main Oct 15, 2025
12 of 15 checks passed
@lkdvos
lkdvos deleted the ld-trunc branch October 15, 2025 13:39
lkdvos referenced this pull request Oct 28, 2025
* Bump v0.15.2

* fix small errors in tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants