fix: regenerate corrupted bun.lock and add explicit packageManager#387
fix: regenerate corrupted bun.lock and add explicit packageManager#387ngoiyaeric wants to merge 1 commit into
Conversation
- Regenerate bun.lock to fix JSON parsing error at line 2683 - Remove 40+ duplicate package entries that were causing build failures - Add packageManager field to package.json to ensure Vercel uses Bun consistently - This fixes the build failure in PR #350 where Vercel was detecting pnpm but using Bun Fixes build error: 'Expected "," but found end of file at bun.lock:2683:2'
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
There was a problem hiding this comment.
No issues found in the shown diff. Adding "packageManager": "bun@1.3.5" is a sensible, low-risk way to pin the expected package manager/version for CI and Vercel consistency.
Additional notes (1)
- Maintainability |
package.json:3-7
PinningpackageManagerto an exact Bun version can improve determinism, but it also creates a maintenance burden and can unnecessarily block builds if your CI/Vercel environment lags that exact version. If the intent is “use Bun consistently” (not necessarily exactly1.3.5), consider allowing patch updates (or documenting why an exact pin is required).
Also, double-check that bun@1.3.5 is actually the minimum version required for this lockfile/regeneration (vs 1.3.x generally).
Summary of changes
What changed
- Added an explicit
packageManagerfield topackage.json:"packageManager": "bun@1.3.5".
Why (per PR context)
- Ensures platforms like Vercel consistently use Bun (and the expected Bun version) when installing dependencies, avoiding mismatches where Bun is used but another lockfile/manager is inferred.
- The accompanying PR description mentions regenerating a corrupted
bun.lock(not shown in this snippet).
PR Code Suggestions ✨No code suggestions found for the PR. |
User description
This PR fixes the build failures in PR #350 by regenerating the corrupted bun.lock file and adding an explicit packageManager field to package.json to ensure Vercel uses Bun consistently.
PR Type
Bug fix
Description
Regenerate corrupted bun.lock file with JSON parsing error
Remove 40+ duplicate package entries causing build failures
Add explicit packageManager field to ensure Vercel uses Bun
Fix build detection mismatch between pnpm and Bun
Diagram Walkthrough
File Walkthrough
package.json
Add explicit Bun package manager specificationpackage.json
packageManagerfield set tobun@1.3.5bun.lock
Regenerate corrupted lock file with duplicates removedbun.lock