fix: Remove invalid --production=false flag from bun install - #395
Conversation
Bun v1.1.3 does not support the --production=false syntax. The --production flag in this version is a boolean flag that does not accept a value. This change removes the flag entirely to install all dependencies including devDependencies, which is the intended behavior when --production=false was used. Fixes the Docker build failure in Google Cloud Build.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
WalkthroughA Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
There was a problem hiding this comment.
No issues found in the modified code. This change correctly aligns the Docker build with Bun v1.1.3 flag semantics and should resolve the reported Cloud Build failure.
Summary of changes
What changed
- Updated the dependency install step in
Dockerfileto remove the invalid Bun flag--production=false. - The install command is now:
RUN bun install --frozen-lockfile
Why
- Bun
v1.1.3treats--productionas a boolean flag and rejects--production=false, which was causing Google Cloud Build failures.
User description
Problem
The Docker build is failing in Google Cloud Build with the following error:
Root Cause
Bun v1.1.3 does not support the
--production=falsesyntax. The--productionflag in this version is a boolean flag that does not accept a value.Solution
This PR removes the
--production=falseflag from thebun installcommand in the Dockerfile. The command now uses:RUN bun install --frozen-lockfileThis installs all dependencies including devDependencies, which is the intended behavior when
--production=falsewas originally used.Testing
This fix resolves the build failure seen in the Google Cloud Build run:
Related
PR Type
Bug fix
Description
Remove invalid
--production=falseflag from bun installFix Docker build failure with Bun v1.1.3 syntax error
Install all dependencies including devDependencies as intended
Diagram Walkthrough
File Walkthrough
Dockerfile
Remove unsupported production flag from bun installDockerfile
--production=falseflag from bun install commandSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.