Skip to content

Update xAI model to Grok 4.3 (grok-latest) #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ngoiyaeric wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update xAI model to Grok 4.3 (grok-latest) #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions code_review_request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Code Review Request: Update xAI Model to Grok 4.3

## Changes:
1. Updated `lib/utils/index.ts`:
- Replaced `Grok 4.2` with `Grok 4.3` in switch cases and error messages.
- Updated model identifier from `grok-4-fast-non-reasoning` to `grok-latest`.
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

The model identifier change documented here is wrong — see comment in lib/utils/index.ts.

This line documents switching from grok-4-fast-non-reasoning to grok-latest, but grok-latest is not a documented xAI model id. Per xAI's official quickstart and models docs, the correct identifier for Grok 4.3 is grok-4.3. Once the source change is corrected, please update this doc accordingly.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@code_review_request.md` at line 6, The doc and the source disagree on the xAI
model id: replace the incorrect `grok-latest` entry in this document with the
correct xAI model identifier `grok-4.3`, and also update the corresponding use
in code (see the model selection in lib/utils/index.ts) so the code and docs
both reference `grok-4.3` consistently.

2. Updated `components/settings/components/settings.tsx`:
- Updated default `selectedModel` to `Grok 4.3`.
3. Updated `components/settings/components/model-selection-form.tsx`:
- Updated `models` array entries from `Grok 4.2` to `Grok 4.3`.

## Verification:
- Targetted unit tests in `lib/utils/index.test.ts` pass.
- Syntax verification using `bun build` for all modified files.
- Verified no remaining occurrences of old model strings.
Comment on lines +3 to +15
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix typo and heading spacing flagged by linters.

  • Line 13: "Targetted" → "Targeted".
  • Lines 3 and 12: add a blank line below each heading to satisfy MD022.
📝 Proposed fix 
 # Code Review Request: Update xAI Model to Grok 4.3

 ## Changes:
+
 1. Updated `lib/utils/index.ts`:
    - Replaced `Grok 4.2` with `Grok 4.3` in switch cases and error messages.
    - Updated model identifier from `grok-4-fast-non-reasoning` to `grok-latest`.
 2. Updated `components/settings/components/settings.tsx`:
    - Updated default `selectedModel` to `Grok 4.3`.
 3. Updated `components/settings/components/model-selection-form.tsx`:
    - Updated `models` array entries from `Grok 4.2` to `Grok 4.3`.

 ## Verification:
-- Targetted unit tests in `lib/utils/index.test.ts` pass.
+
+- Targeted unit tests in `lib/utils/index.test.ts` pass.
 - Syntax verification using `bun build` for all modified files.
 - Verified no remaining occurrences of old model strings.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Changes:
1. Updated `lib/utils/index.ts`:
- Replaced `Grok 4.2` with `Grok 4.3` in switch cases and error messages.
- Updated model identifier from `grok-4-fast-non-reasoning` to `grok-latest`.
2. Updated `components/settings/components/settings.tsx`:
- Updated default `selectedModel` to `Grok 4.3`.
3. Updated `components/settings/components/model-selection-form.tsx`:
- Updated `models` array entries from `Grok 4.2` to `Grok 4.3`.
## Verification:
- Targetted unit tests in `lib/utils/index.test.ts` pass.
- Syntax verification using `bun build` for all modified files.
- Verified no remaining occurrences of old model strings.
## Changes:
1. Updated `lib/utils/index.ts`:
- Replaced `Grok 4.2` with `Grok 4.3` in switch cases and error messages.
- Updated model identifier from `grok-4-fast-non-reasoning` to `grok-latest`.
2. Updated `components/settings/components/settings.tsx`:
- Updated default `selectedModel` to `Grok 4.3`.
3. Updated `components/settings/components/model-selection-form.tsx`:
- Updated `models` array entries from `Grok 4.2` to `Grok 4.3`.
## Verification:
- Targeted unit tests in `lib/utils/index.test.ts` pass.
- Syntax verification using `bun build` for all modified files.
- Verified no remaining occurrences of old model strings.
🧰 Tools
🪛 LanguageTool

[grammar] ~12-~12: Ensure spelling is correct
Context: ...ok 4.2toGrok 4.3. ## Verification: - Targetted unit tests in lib/utils/index.test.ts`...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🪛 markdownlint-cli2 (0.22.1)

[warning] 3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

[warning] 12-12: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@code_review_request.md` around lines 3 - 15, Fix the lint issues in the PR
description: correct the typo "Targetted" to "Targeted" in the "Verification:"
section and insert a blank line immediately after the "## Changes:" and "##
Verification:" headings to satisfy MD022; update the heading spacing and the
single-word typo in the markdown content so the headings "## Changes:" and "##
Verification:" each have one blank line below them and the word "Targetted" is
replaced with "Targeted".

4 changes: 2 additions & 2 deletions components/settings/components/model-selection-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ const models = [
badgeVariant: "default" as const,
},
{
id: "Grok 4.2",
name: "Grok 4.2",
id: "Grok 4.3",
name: "Grok 4.3",
description: "The latest from xAI, pushing the boundaries of reasoning and problem-solving.",
icon: Rocket,
badge: "New",
Expand Down
2 changes: 1 addition & 1 deletion components/settings/components/settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export type SettingsFormValues = z.infer<typeof settingsFormSchema>
const defaultValues: Partial<SettingsFormValues> = {
systemPrompt:
"You are a planetary copilot, an AI assistant designed to help users with information about planets, space exploration, and astronomy. Provide accurate, educational, and engaging responses about our solar system and beyond.",
selectedModel: "Grok 4.2",
selectedModel: "Grok 4.3",
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Persisted user preferences for "Grok 4.2" are now orphaned — consider a migration or normalization.

Existing users who previously saved "Grok 4.2" via saveSelectedModel will hit two problems on next load:

  1. In useEffect at lines 96–98, form.setValue("selectedModel", "Grok 4.2", …) sets the radio group to a value that no longer exists in models[] in model-selection-form.tsx, so no card appears selected and the user sees an apparently-empty selection.
  2. getModel in lib/utils/index.ts no longer has a case 'Grok 4.2', so requests silently fall through to the xAI default-fallback chain — masking the misconfiguration.

Options: (a) backfill stored values from "Grok 4.2" → "Grok 4.3" in getSelectedModel / a one-time migration; (b) normalize unknown values to defaultValues.selectedModel in the useEffect before calling setValue; (c) keep a case 'Grok 4.2' in getModel mapped to grok-4.3 for backward compatibility.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@components/settings/components/settings.tsx` at line 57, User prefs saved as
"Grok 4.2" are now invalid and cause the UI and getModel to misbehave; update
the settings load path to normalize or migrate that value. In the component
containing the useEffect that calls form.setValue("selectedModel", …)
(settings.tsx) detect unknown persisted values (via
getSelectedModel/saveSelectedModel) and map "Grok 4.2" → "Grok 4.3" (or fallback
to defaultValues.selectedModel) before calling form.setValue so the radio group
in model-selection-form.tsx matches models[], and also add a backward-compatible
mapping in getModel (lib/utils/index.ts) to treat 'Grok 4.2' as the same as
'grok-4.3' if you prefer compatibility instead of migration.

users: [],
}

Expand Down
10 changes: 5 additions & 5 deletions lib/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,20 @@ export async function getModel(requireVision: boolean = false) {

if (selectedModel) {
switch (selectedModel) {
case 'Grok 4.2':
case 'Grok 4.3':
if (xaiApiKey) {
const xai = createXai({
apiKey: xaiApiKey,
baseURL: 'https://api.x.ai/v1',
});
try {
return xai('grok-4-fast-non-reasoning');
return xai('grok-latest');
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

Does the xAI API expose a "grok-latest" alias, or is "grok-4.3" the only public identifier for Grok 4.3? Cite docs.x.ai.

💡 Result:

No, the xAI API does not expose a "grok-latest" alias. "grok-4.3" is the primary public identifier for Grok 4.3, with model-specific aliases like "grok-4.3-latest" available according to official documentation [1][2]. The xAI docs describe a general alias pattern where specific models use "-latest" for the latest version of that model, and a blank alias for the latest stable version, but no source explicitly lists or confirms a generic "grok-latest" alias [1][3][2]. Examples for other models include "grok-4-latest" [4] and "grok-4.20-reasoning-latest" [5], following the per-model pattern. Secondary sources mention "grok-4.3-latest" specifically for Grok 4.3 [6]. API examples and model lists consistently use "grok-4.3" directly [7].

Citations:

Critical: grok-latest is not a documented xAI model id — this will fail at request time.

xAI's official documentation at docs.x.ai/developers/models confirms that the canonical identifier for Grok 4.3 is grok-4.3. The xAI API does not expose a grok-latest alias; requests using this identifier will be rejected. The model-specific alias pattern (e.g., grok-4.3-latest) follows a per-model convention, not a generic grok-latest.

Two consequences:

  1. Both the explicit case 'Grok 4.3' branch (line 44) and the default xAI fallback (line 88) send grok-latest to the xAI API, which will reject it. Every code path with XAI_API_KEY set is broken.
  2. The try/catch on lines 43–48 will not catch this: xai(...) is a synchronous factory that returns a model handle without contacting the API, so an invalid model id surfaces later in the consumer call stack.

Use the documented identifier grok-4.3.

🔧 Proposed fix 
       case 'Grok 4.3':
         if (xaiApiKey) {
           const xai = createXai({
             apiKey: xaiApiKey,
             baseURL: 'https://api.x.ai/v1',
           });
           try {
-            return xai('grok-latest');
+            return xai('grok-4.3');
           } catch (error) {
             console.error('Selected model "Grok 4.3" is configured but failed to initialize.', error);
             throw new Error('Failed to initialize selected model.');
           }
         } else {
@@
   if (xaiApiKey) {
     const xai = createXai({
       apiKey: xaiApiKey,
       baseURL: 'https://api.x.ai/v1',
     });
     try {
-      return xai('grok-latest');
+      return xai('grok-4.3');
     } catch (error) {
       console.warn('xAI API unavailable, falling back to next provider:');
     }
   }

Also applies to: 88-88

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/utils/index.ts` at line 44, The code returns an undocumented xAI model id
'grok-latest' from the xai(...) factory (e.g., in the branch that returns
xai('grok-latest') and the default xAI fallback), which will be rejected by the
API; update all occurrences to the documented identifier 'grok-4.3' in the
factory calls (replace xai('grok-latest') with xai('grok-4.3') in the function
that chooses models in lib/utils/index.ts), and ensure any related default
fallback logic also uses 'grok-4.3'—note that xai(...) is synchronous so this
change must be made where the model handle is created, not just in downstream
try/catch blocks.

} catch (error) {
console.error('Selected model "Grok 4.2" is configured but failed to initialize.', error);
console.error('Selected model "Grok 4.3" is configured but failed to initialize.', error);
throw new Error('Failed to initialize selected model.');
}
} else {
console.error('User selected "Grok 4.2" but XAI_API_KEY is not set.');
console.error('User selected "Grok 4.3" but XAI_API_KEY is not set.');
throw new Error('Selected model is not configured.');
}
Comment on lines +37 to 52
Copy link
Copy Markdown
Contributor

@qodo-code-review qodo-code-review Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Grok 4.2 ignored 🐞 Bug ≡ Correctness

Existing users with a persisted selectedModel value of "Grok 4.2" will no longer match any case in
getModel(), so their stored preference is silently ignored and the function falls back to the
default provider order. The settings UI also won’t present "Grok 4.2" as an option anymore, but the
form still treats the stale value as valid and can keep re-saving it unchanged.
Agent Prompt 
### Issue description
Persisted user settings may still contain `selectedModel = "Grok 4.2"`, but the PR removed all handling for that value. As a result, `getModel()` ignores the user’s stored preference and falls back to the default provider chain.

### Issue Context
- `users.selectedModel` is stored as free-form text and returned verbatim.
- Settings loads this value into the form.
- UI options and `getModel()` no longer recognize `"Grok 4.2"`.

### Fix Focus Areas
- lib/utils/index.ts[35-79]
- lib/actions/users.ts[146-182]
- components/settings/components/settings.tsx[84-98]
- components/settings/components/model-selection-form.tsx[28-61]

### Suggested fix
- Treat `"Grok 4.2"` as a legacy alias:
  - Add `case 'Grok 4.2':` in `getModel()` and route it to the same code path as `"Grok 4.3"` (or normalize before the switch).
  - Prefer central normalization in `getSelectedModel()` (e.g., map `'Grok 4.2' -> 'Grok 4.3'`) so both server selection and settings UI receive the updated value.
- Optionally, on settings load, if the DB returns `"Grok 4.2"`, update the form value to `"Grok 4.3"` (and optionally persist the updated value via `saveSelectedModel`).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Comment on lines 38 to 52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial | 💤 Low value

Synchronous xai(...) factory inside try/catch gives a false sense of safety.

createXai(...) and the returned xai(modelId) are synchronous factories; they don't issue a network request, so neither an invalid model id nor a downstream xAI outage will be caught here. The model is only exercised when the caller awaits a generation. If the goal is to surface initialization failures distinctly from API failures, validate xaiApiKey (already done) and let the caller wrap the actual generation call in error handling — the current try/catch is dead defensive code.

The same observation applies to the Gemini 3 block (lines 58–63) and the fallback paths.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/utils/index.ts` around lines 38 - 52, The try/catch around the
synchronous factory call createXai(...) and its returned invocation
xai('grok-latest') should be removed because neither performs network I/O;
simply return xai('grok-latest') after validating xaiApiKey, and delete the
console.error/throw that falsely treats factory invocation as an initialization
failure; apply the same change to the analogous Gemini factory block (the
create* factory and its factory(modelId) call) and any fallback branches so that
actual API/network errors are surfaced by callers when they await generation
rather than being caught here.

case 'Gemini 3':
Expand Down Expand Up @@ -85,7 +85,7 @@ export async function getModel(requireVision: boolean = false) {
baseURL: 'https://api.x.ai/v1',
});
try {
return xai('grok-4-fast-non-reasoning');
return xai('grok-latest');
} catch (error) {
console.warn('xAI API unavailable, falling back to next provider:');
}
Comment on lines 89 to 91
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fallback warn discards the caught error and is misleading.

console.warn('xAI API unavailable, falling back to next provider:') ends with a colon but logs nothing after it, and the error is captured but not printed. Compare with line 101 which logs error. More importantly, as noted above, this branch will never run for an invalid model id since xai('grok-4.3') does not throw — so the "fallback" you appear to expect doesn't actually trigger when xAI rejects the model.

📝 Suggested log fix 
-    } catch (error) {
-      console.warn('xAI API unavailable, falling back to next provider:');
-    }
+    } catch (error) {
+      console.warn('xAI API unavailable, falling back to next provider:', error);
+    }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
} catch (error) {
console.warn('xAI API unavailable, falling back to next provider:');
}
} catch (error) {
console.warn('xAI API unavailable, falling back to next provider:', error);
}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/utils/index.ts` around lines 89 - 91, The catch block that calls
console.warn('xAI API unavailable, falling back to next provider:') swallows the
caught error and prints a misleading colon; change this to include the actual
caught error object in the log (e.g., console.warn('xAI API unavailable, falling
back to next provider:', error) or use console.error) so the error details are
preserved, and update the control flow around the xai('grok-4.3') call to not
rely solely on exceptions for invalid model IDs—instead inspect the xAI call
result/response for an error/invalid-model indicator and trigger the fallback
when that response indicates an invalid model (e.g., check returned error/status
or response.error) rather than waiting for a thrown exception.

Expand Down