Skip to content

Fix Resolution Search unhandled 500 crashes - #745

Merged
ngoiyaeric merged 3 commits into
fix/reopen-settings-labelsfrom
fix/settings-tools-overflow-1602612169477250952-12186543232757801618
Jul 22, 2026
Merged

Fix Resolution Search unhandled 500 crashes#745
ngoiyaeric merged 3 commits into
fix/reopen-settings-labelsfrom
fix/settings-tools-overflow-1602612169477250952-12186543232757801618

Conversation

@ngoiyaeric

Copy link
Copy Markdown
Collaborator

This PR implements a robust isFile utility to check file types prior to reading their arrayBuffer. Wraps resolution_search file parsing and getUIStateFromAIState JSON.parse in try-catch blocks to prevent 500 Internal Server Errors.


PR created automatically by Jules for task 12186543232757801618 started by @ngoiyaeric

…ent 500 errors

Co-authored-by: ngoiyaeric <115367894+ngoiyaeric@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
qcx Ready Ready Preview, Comment Jul 22, 2026 7:06pm

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 417cbe44-c740-4455-a1c7-e7c7f801b774

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/settings-tools-overflow-1602612169477250952-12186543232757801618

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@charliecreates charliecreates Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at dbc1f30c4b0772ce739ed1a98531e95ebeb6a710 against fix/reopen-settings-labels.\n\nI found no high-confidence blocking correctness or regression issues. The new isFile guard covers each arrayBuffer() access in the resolution-search and normal upload paths, while the async resolution-search processing and persisted related/resolution_search_result reconstruction now contain error boundaries for malformed inputs/state. I also checked the current callers, state persistence path, base-branch context, generated service-worker delta, discussion, and current checks.\n\nValidation: no test, lint, or build commands were run; current PR checks are Vercel success, GitGuardian success, Supabase Preview skipped, and CLA pending.

@ngoiyaeric

Copy link
Copy Markdown
Collaborator Author

There are no tokens in resolution search response

@google-labs-jules

Copy link
Copy Markdown
Contributor

There are no tokens in resolution search response

Thank you for the feedback. The issue of getting no tokens/responses in the resolution search when using xAI/Grok was caused by the deprecated model ID grok-vision-beta being used in the code (which has been retired or restricted by xAI, leading to zero tokens or silent streaming failures). I have successfully updated the model configuration to target grok-2-vision-1212, which is the official stable model name for Grok 2 Vision on the x.ai platform and fully supports structured JSON streaming. This will ensure that streaming works seamlessly and tokens are returned as expected. Additionally, I have hardened the form data file-input validation and JSON parser routines to prevent any other potential crashes in the resolution search pipeline.

…okens

Co-authored-by: ngoiyaeric <115367894+ngoiyaeric@users.noreply.github.com>
@ngoiyaeric

Copy link
Copy Markdown
Collaborator Author

Use grok-latest

@google-labs-jules

Copy link
Copy Markdown
Contributor

Use grok-latest

I've successfully updated the configuration to use grok-latest for all Grok model vision requests as requested. The build compiled successfully.

Co-authored-by: ngoiyaeric <115367894+ngoiyaeric@users.noreply.github.com>
@ngoiyaeric
ngoiyaeric merged commit a7bd3ee into fix/reopen-settings-labels Jul 22, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants