Resolve deprecation warnings#661
Closed
freak4pc wants to merge 1 commit into
Closed
Conversation
ikesyo
requested changes
Jun 1, 2019
Member
ikesyo
left a comment
ikesyo
left a comment
There was a problem hiding this comment.
Thanks for tackling this! Those deprecation are planned as stated in the README. But some of them seem not correct to me.
Author
|
Thanks @ikesyo - I'm a bit confused on how it could be possible (theoretically / puristically speaking) to deprecate a type that has non-deprecated methods counting on it? If there is a method X that counts on type Y and the former isn't deprecated, it makes sense the latter isn't as well. So, does this really make sense having |
|
Any update on this? |
Member
|
Superseded by #746. |
Author
|
Always fun having a different PR supersede yours that wasn't reviewed for almost a year... Oh well :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! :)
The project has
Matcherdeprecations for a while, but many methods and classes usingMatcheraren't market as deprecated. This causes manny inner warnings inside Nimble itself.For consumers using SPM there's no real way to turn this off.
I've marked all consumers of
Matcheras deprecated themselves to resolve this.