🔥 Remove deprecated matcher#739
Closed
phatblat wants to merge 2 commits into
Closed
Conversation
ikesyo
requested changes
May 4, 2020
Member
ikesyo
left a comment
There was a problem hiding this comment.
Let's consider the deprecation roadmap in the README: https://github.com/Quick/Nimble/blob/master/README.md#deprecation-roadmap
- We need to do the following before removing the APIs
-
Introduce warnings on migration-path features (.predicate, Predicate-constructors with similar arguments to old API).
-
- The README change in #689 needs to be reverted
Member
|
Submitted #746 for migration-path features deprecation. |
Member
|
Superseded by #746. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are we ready for this yet? Looks like v9 work has started in master and this might be a good time to drop the deprecated
Matcher.Tests still need some work; they compile but I still need to track down crashes.
The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:
Checklist - While not every PR needs it, new features should consider this list: