Skip to content

Conversation

@Oliver-makes-code
Copy link
Contributor

This RFC aims to define the Quilt Kotlin Team, and its uses

@Oliver-makes-code
Copy link
Contributor Author

So, for the Drawbacks part, I left it as "TBD" because we can find drawbacks for it through discussion. There's also the unresolved questions, the first of which, "Should this be a subdivision QSL?"

@Oliver-makes-code
Copy link
Contributor Author

QKL shouldn't be a subdivision of QSL, as QSL is based on Java, it'd be
difficult for maintainers who don't know Kotlin to be able to maintain QKL.
Having QKL as a subdivision of QSL would mean that changes in the respective
QSL modules would have to be copied to the QKL module before merging. This is a
bad idea, because it forces everyone to know Kotlin to be able to contribute.

@Oliver-makes-code
Copy link
Contributor Author

Kotlin's interoperability with Java is just that, interoperability. There are some ideas that work well in Java, but not Kotlin, and vice versa. Extension functions and DSLs don't exist in Java, and with this we'd provide essential ones for modding in Kotlin. Also once CHASM is added to loader, we can provide an official front end for it in Kotlin

@Southpaw1496
Copy link
Contributor

Couple of things:

  • Firstly, if this team's sole purpose is making QKL, shouldn't they be the QKL team, just like the people making QSL are the QSL team? I understand there has been discussion about building Kotlin wrappers for things outside QSL (which I am all for), but that's been put under "Unresolved Questions".
  • Secondly, if QKL will be for QSL libraries, wouldn't that be something like Quilt Standard Libraries Kotlin, or Quilt Standard Kotlin Libraries, not Quilt Kotlin Libraries? The name is inconsistent with QSL (it's not Quilt Java Libraries, after all).

@Oliver-makes-code
Copy link
Contributor Author

  • Firstly, if this team's sole purpose is making QKL, shouldn't they be the QKL team, just like the people making QSL are the QSL team? I understand there has been discussion about building Kotlin wrappers for things outside QSL (which I am all for), but that's been put under "Unresolved Questions".

The main reason is that Quilt Kotlin Team rolls off the tongue better, but it can be changed to QKL team if need be

  • Secondly, if QKL will be for QSL libraries, wouldn't that be something like Quilt Standard Libraries Kotlin, or Quilt Standard Kotlin Libraries, not Quilt Kotlin Libraries? The name is inconsistent with QSL (it's not Quilt Java Libraries, after all).

QKL will be separate from QSL

@Southpaw1496
Copy link
Contributor

Southpaw1496 commented Apr 28, 2022

QKL will be separate from QSL

I know, but since you're porting the standard libraries, it makes sense to say as much in the name.

@Oliver-makes-code
Copy link
Contributor Author

We're not porting the standard libraries, per se, we're wrapping the libraries to make it feel more familiar to kotlin developers

@Oliver-makes-code
Copy link
Contributor Author

Oliver-makes-code commented May 7, 2022

All that's still TBD is the Drawbacks section. After that is filled out I can mark ready for review

@SilverAndro
Copy link
Contributor

The main drawback I can think of is that QKL may get out of date with QSL and/or the versioning scheme may cause confusion with QSL versioning (i.e QSL updates to 1.0.1 but QKL sticks on 1.0.0 as its not breaking) although that could be mitigated somewhat with minimum QSL version requirements

@Oliver-makes-code Oliver-makes-code marked this pull request as ready for review May 15, 2022 16:14
@Oliver-makes-code
Copy link
Contributor Author

Open for review \o/

Copy link
Contributor

@Southpaw1496 Southpaw1496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not too hot on the name "QKL" (I think QSLK would make more sense), that is a very minor complaint and other than that it seems like an excellent idea.

Copy link

@NoComment1105 NoComment1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Oliver-makes-code
Copy link
Contributor Author

Oliver-makes-code commented May 16, 2022

I think QSLK would make more sense

@Southpaw1496
The main reason I'm not going with QSLK is due to the fact it would cause people to presume it's a subdivision of QSL, which it's not

Copy link
Contributor

@SilverAndro SilverAndro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@CheaterCodes
Copy link
Contributor

In accordance with the (not yet implemented) Governance Amendment #47, I would like to see you propose initial team members and the initial team lead. This would not be part of the RFC, but should at least be mentioned in a comment here so that people can approve of it.

@Oliver-makes-code
Copy link
Contributor Author

In accordance with the (not yet implemented) Governance Amendment #47, I would like to see you propose initial team members and the initial team lead. This would not be part of the RFC, but should at least be mentioned in a comment here so that people can approve of it.

I can be the initial team lead, and @NoComment1105, @P03W, and I can be the initial members. @gdude2002 said he'd consider joining at a later date

@sschr15
Copy link
Member

sschr15 commented May 16, 2022

I'd like to be an initial member as well

@PotatoPresident
Copy link
Member

Definitely would like to be a member

Copy link

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'd like to be in the team as well

@ghost
Copy link

ghost commented May 18, 2022

I also would like to be in the team. 😊

@gdude2002
Copy link
Contributor

I think it's necessary to point out that you can contribute without being on the team - it should not be a large team, and the people on it should be there to steer the projects that the team is responsible for, not just because they want to help with the projects.

@Oliver-makes-code
Copy link
Contributor Author

Now that this has approval from all 3 admins this should be able to enter FCP

@OroArmor OroArmor added the final-comment RFCs in the final comment period. label May 29, 2022
@OroArmor OroArmor merged commit 0f00bd5 into QuiltMC:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

final-comment RFCs in the final comment period.

Projects

None yet

Development

Successfully merging this pull request may close these issues.