Skip to content

chore (package.json) :improve windows support#7399

Merged
wmertens merged 2 commits intoQwikDev:mainfrom
Shane-Donlon:chore-improve-win-support
Mar 14, 2025
Merged

chore (package.json) :improve windows support#7399
wmertens merged 2 commits intoQwikDev:mainfrom
Shane-Donlon:chore-improve-win-support

Conversation

@Shane-Donlon
Copy link
Contributor

What is it?

  • Bug

Description

Hey everyeone:
Another PR just to improve the compatibility of the package.json for Windows.

This has been tested on the below Operating Systems:
OS: Windows 11 10.0.26100
OS: Linux 6.8 Linux Mint 22.1 (Xia)

Summary:

  1. build.clean:
    this was moved to a tsx approach rm rf doesn't work on Windows OS.
    this requires a pnpm install but should be fine as a build would also be required.

  2. docs.preview:
    the cd packages/docs && pnpm preview style commands do not work on Windows.
    moved to PNPM -C for cross platform support.

As a note:
link.dist &&"link.dist.yarn": && "link.dist.npm": currently do not work cross platform,
But they do not appear to be frequently needed.

I think this is the last one of these PR's for a while as visual check confirms all other commands should be fine.

Checklist

@Shane-Donlon Shane-Donlon requested a review from a team as a code owner March 7, 2025 16:51
@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: 1e9b3e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7399
npm i https://pkg.pr.new/@builder.io/qwik-city@7399
npm i https://pkg.pr.new/eslint-plugin-qwik@7399
npm i https://pkg.pr.new/create-qwik@7399

commit: 1e9b3e1

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1e9b3e1

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 62e5f9a into QwikDev:main Mar 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants