chore (package.json) :improve windows support#7399
Merged
wmertens merged 2 commits intoQwikDev:mainfrom Mar 14, 2025
Merged
Conversation
|
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Hey everyeone:
Another PR just to improve the compatibility of the package.json for Windows.
This has been tested on the below Operating Systems:
OS: Windows 11 10.0.26100
OS: Linux 6.8 Linux Mint 22.1 (Xia)
Summary:
build.clean:
this was moved to a tsx approach
rm rfdoesn't work on Windows OS.this requires a
pnpm installbut should be fine as a build would also be required.docs.preview:
the
cd packages/docs && pnpm previewstyle commands do not work on Windows.moved to
PNPM -Cfor cross platform support.As a note:
link.dist&&"link.dist.yarn":&&"link.dist.npm":currently do not work cross platform,But they do not appear to be frequently needed.
I think this is the last one of these PR's for a while as visual check confirms all other commands should be fine.
Checklist