Skip to content

[Backport stable20] support ocrmypdf#32 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
R0Wi merged 1 commit into from
Nov 30, 2020
Merged

[Backport stable20] support ocrmypdf#32 #40

R0Wi merged 1 commit into from
Nov 30, 2020

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Nov 30, 2020

Backport 7664ef9 from #39

@R0Wi @bahnwaerter @github-actions
support ocrmypdf#32 (#39)
f314e67 
* First working version with OCRmyPDF #32

* Fix variable assignment

* Use ProcessingFileAccessor to prevent infinite loop

* Update README for OCRmyPDF

* docs: update TOC

* Update README + app compliance

* Code compliance

* Apply suggestions from code review

Co-authored-by: Manuel Bentele <development@manuel-bentele.de>

Co-authored-by: R0Wi <R0Wi@users.noreply.github.com>
Co-authored-by: Manuel Bentele <development@manuel-bentele.de>
@R0Wi R0Wi self-requested a review November 30, 2020 20:29
@codecov
Copy link

codecov bot commented Nov 30, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (stable20@8aa6e6f). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable20      #40   +/-   ##
===========================================
  Coverage            ?   99.53%           
  Complexity          ?       83           
===========================================
  Files               ?       13           
  Lines               ?      217           
  Branches            ?        0           
===========================================
  Hits                ?      216           
  Misses              ?        1           
  Partials            ?        0
Impacted Files Coverage Δ Complexity Δ
lib/AppInfo/Application.php 100.00% <100.00%> (ø) 6.00 <0.00> (?)
lib/BackgroundJobs/ProcessFileJob.php 100.00% <100.00%> (ø) 20.00 <1.00> (?)
lib/Helper/ProcessingFileAccessor.php 100.00% <100.00%> (ø) 7.00 <7.00> (?)
lib/OcrProcessors/PdfOcrProcessor.php 100.00% <100.00%> (ø) 5.00 <1.00> (?)
lib/Operation.php 100.00% <100.00%> (ø) 23.00 <7.00> (?)
lib/Wrapper/CommandWrapper.php 100.00% <100.00%> (ø) 8.00 <7.00> (?)
lib/Wrapper/ViewWrapper.php 85.71% <100.00%> (ø) 3.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa6e6f...f314e67. Read the comment docs.

@R0Wi R0Wi closed this Nov 30, 2020
@R0Wi R0Wi reopened this Nov 30, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@R0Wi R0Wi merged commit 75ad9f9 into stable20 Nov 30, 2020
@R0Wi R0Wi deleted the backport-39-to-stable20 branch November 30, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@R0Wi R0Wi Awaiting requested review from R0Wi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@R0Wi