docs: compound learnings from v1.3.0 and GP reranking#10
Conversation
…to AGENTS.md Captures architectural decisions and lessons from recent work: - 429 handling: coordinator must see all outcomes (dispatch returns Err, not Ok with 429 status) so EWMA and GP can track failures - GP reranker pinned-prefix pattern for direct-routing compatibility - AppState field additions require updating all test build_app() helpers - External gp-routing path dependency requires sibling checkout - Updated request flow, key files table, and error handling docs Amp-Thread-ID: https://ampcode.com/threads/T-019d7c98-ce13-7515-a44f-9df4478428ca Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e9f8dfb40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates AGENTS.md to consolidate recent architectural learnings around tier ordering (EWMA + direct-routing pins), optional GP-based reranking, and rate-limit handling, plus a few repo maintenance/testing notes.
Changes:
- Updates the request-flow diagram to reflect pinned-prefix handling and optional GP reranking.
- Extends the “key files” table to include
src/gp_router.rs. - Expands error-handling + “Lessons Learned” documentation (429 handling rationale, pinned-prefix pattern, AppState test helper updates, and
gp-routingpath dependency).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks again for the PR — the learnings you pulled in here are useful. One bit of context for With that in mind, I’d like to keep the accurate reusable notes here, but compact them:
I’d drop the separate 429 subsection and fold that behavior into the shorter wording above. That keeps I’ve also resolved the bot threads in favor of this higher-level rewrite request rather than taking the line-by-line suggestions literally. Thanks again — the underlying lessons are useful; I’d just like the final doc version to be tighter and more onboarding-oriented. |
Compounds architectural learnings from recent work into AGENTS.md:
Err(RateLimited)instead of pass-through — coordinator must see all outcomes for EWMA/GP trackingbuild_app()in tests must be updated when AppState growsgp-routingcrate requires sibling checkoutPrevious compounding threads (T-019d77e8, T-019d777b) could not push to origin; this PR consolidates their learnings plus new GP reranking patterns.