change path selector modal overflow behavior#1
Merged
mnakao merged 1 commit intoRIKEN-RCCS:mainfrom Feb 3, 2025
Merged
Conversation
mnakao
approved these changes
Feb 3, 2025
Contributor
mnakao
left a comment
mnakao
left a comment
There was a problem hiding this comment.
Thank you for your excellent feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would prefer the path selector widget to work differently. It now creates a modal popup and if the folder contains a lot of files the modal overflows and you always have to scroll to the bottom to click on the select button. I would prefer a modal with fixed height and a scroll bar in the modal body to scroll through the file list. Thanks for this great app.