[Fix] Align tensor integer storage with pointer types - #700
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to align how integer tensor element types are represented in MLIR across the Python JIT argument layer (Torch tensors) and the DLPack adaptor, by switching integer MLIR types to “signless”.
Changes:
- Updated
torch.dtype→ MLIR integer type mapping to use signless integer types. - Updated DLPack
kDLInt/kDLUInt→ MLIR integer type mapping to use signless integer types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python/flydsl/compiler/jit_argument.py | Changes Torch tensor dtype-to-MLIR type mapping for integer dtypes. |
| lib/Bindings/Python/DLTensorAdaptor.h | Changes DLPack dtype-to-MLIR type mapping for signed/unsigned integers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
#701 tracks the remaining problem of losing signedness |
coderfeli
approved these changes
Jun 17, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist