[Feat] Add fx.num_warp_threads() as constant accessor - #996
Open
sjfeng1999 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new constant accessor in the Python DSL GPU intrinsics layer so kernel authors can query the target warp (subgroup) lane count as a Python int.
Changes:
- Add
fx.num_warp_threads()inflydsl.expr.gpureturningcurrent_target().warp_size. - Add
current_target()convenience accessor toflydsl.compiler.backendsand export it publicly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/flydsl/expr/gpu.py | Exposes num_warp_threads() in the GPU intrinsics namespace (but currently introduces an import-time dependency that should be made lazy). |
| python/flydsl/compiler/backends/init.py | Adds current_target() helper returning the active backend’s GPUTarget. |
Suppressed comments (1)
python/flydsl/expr/gpu.py:122
- num_warp_threads() relies on current_target, but current_target is imported at module scope. After removing the module-scope import, add a local import here (matching the existing pattern in expr/primitive.py) to avoid backend registry side effects during flydsl.expr import.
def num_warp_threads():
"""Lanes per warp on the target being compiled for, as a Python int."""
return current_target().warp_size
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist