[CP 1337] [Fix] Add workflow and workflow-triggered pod collection to techsupport#522
Open
ci-penbot-01 wants to merge 1 commit intoROCm:mainfrom
Conversation
…rt (#1337) * Add workflow and workflow-triggered pod collection to techsupport Enhance the techsupport_dump.sh script to collect workflow CRs and workflow-triggered pods when auto node remediation feature is enabled. This helps with debugging workflow-based node remediation issues. Changes: - Add WORKFLOW_RESOURCES variable for workflow CRs - Collect workflow CRs (get, describe, yaml/json output) - Collect workflow-triggered pods identified by workflows.argoproj.io/workflow label - Add per-node log collection for workflow-triggered pods - Include error resilience with || true for ephemeral workflow pods Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Make pod_logs function resilient to ephemeral pod failures Add error handling (|| true) to kubectl logs commands in pod_logs function to prevent script termination when collecting logs from ephemeral/terminated workflow pods. With set -e enabled, failed log collection would previously abort the entire techsupport run before reaching error handlers. Changes: - Add '2>&1 || true' to current container logs command - Add '2>&1 || true' to previous container logs command - Ensures individual pod log failures don't terminate script execution - Critical for short-lived workflow pods that may be deleted during collection Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add workflow controller pod collection to techsupport Collect information and logs from the workflow controller pod (identified by label app=amd-gpu-operator-workflow-controller) in addition to workflow CRs and workflow-triggered pods. Changes: - Add workflow controller pod collection in cluster-wide section - kubectl get/describe output in both text and JSON/YAML format - Add workflow controller pod log collection per node - Maintains error resilience with || true for optional feature Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> (cherry picked from commit 70b0104643e7b5d2239bd7ec4851ed9706618c6c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of pensando/gpu-operator#1337
Source PR Description (pensando/gpu-operator#1337):
https://pensando.atlassian.net/browse/GPUOP-622
Enhance the techsupport_dump.sh script to collect workflow CRs and workflow-triggered pods when auto node remediation feature is enabled. This helps with debugging workflow-based node remediation issues.
Changes:
Cherrypick triggered by: ACP-Automation