rename: 'rocm doctor' subcommand to 'rocm examine'

[rominf]

Summary

Renames the rocm doctor subcommand to rocm examine throughout the codebase.
examine better describes what the command does — it inspects and reports system
state — and avoids a naming collision with external tooling that uses the "doctor"
convention for different purposes.

Changes

• CLI command: rocm doctor → rocm examine
• TUI command: /doctor → /examine
• MCP/OpenAI tool name: "doctor" → "examine"
• Restricted sandbox tool: doctor_snapshot → examine_snapshot (enum
  DoctorSnapshot → ExamineSnapshot), and the CodexBridgeSnapshot payload
  key doctor → examine
• All internal Rust identifiers (DoctorSummary → ExamineSummary, etc.)
• File rename: doctor_manager.rs → examine_manager.rs
• All user-visible help text, error messages, docs, install scripts, and
  CI/smoke/acceptance scripts

Decisions

• No backwards-compat alias. rocm doctor is a deliberate hard rename — no
  hidden doctor alias — so existing rocm doctor invocations now error. The
  command is pre-1.0 and the clean break keeps the surface coherent.
• Wire format. examine_snapshot and CodexBridgeSnapshot belong to the
  rocmd-codex-bridge-v0 protocol, which has no stability guarantee yet, so the
  tool name and payload key were renamed in full rather than aliased.

Test plan

• cargo build --workspace and full cargo test --workspace pass clean
• Three slash-completion/editing tests updated to the new prefix (/exa, /ex)
• cargo fmt --check and cargo clippy --workspace clean

[Copilot]

Pull request overview

This PR renames the rocm doctor inspection surface to rocm examine across the CLI, TUI, MCP/OpenAI tool integrations, docs, and CI/scripts to better reflect the command’s purpose and avoid “doctor” naming collisions.

Changes:

• Renamed user-facing CLI/TUI command surfaces: doctor → examine (including help text, prompts, and slash-command completions).
• Updated MCP/OpenAI tool naming and related Rust types (DoctorSummary → ExamineSummary, etc.), plus updated scripts/CI smoke paths.
• Refreshed documentation and plans to reference examine instead of doctor.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
scripts/smoke_local.py	Updates local smoke to run/assert rocm examine output.
scripts/acceptance-install-upgrade-tui-uninstall.ps1	Updates acceptance script log naming and calls to rocm examine.
README.md	Replaces quick-start “doctor” invocation with “examine”.
plans/rocm-cli-remaining-implementation-plan.md	Updates plan references from doctor → examine.
plans/rocm-cli-pytorch-engine-spec.md	Updates spec references from doctor → examine.
plans/rocm-cli-implementation-plan.md	Updates implementation plan references from doctor → examine.
plans/cosmopolitan-runtime-boundary-plan.md	Updates plan/test command references to examine.
install.sh	Updates post-install guidance to run rocm examine.
install.ps1	Updates post-install guidance to run rocm examine.
docs/wsl.md	Updates section heading and references to rocm examine.
docs/ux-guidelines.md	Updates UX guidance text referencing “Doctor” to “Examine”.
docs/testing.md	Updates testing instructions and tool-call examples to examine.
docs/manual-testing.md	Updates manual test instructions to rocm examine.
docs/implementation-completion-audit.md	Updates audit doc references from Doctor → Examine.
docs/current-tui-therock-correction-plan.md	Updates doc references from doctor → examine.
docs/cosmopolitan-universal-binary-plan.md	Updates universal-binary plan references from doctor → examine.
docs/codex-vendoring-plan.md	Updates vendoring plan tool/surface references to examine.
docs/automations.md	Updates restricted tool docs wording for doctor_snapshot vs examine.
crates/rocm-dash-tui/src/ui/tabs/instances.rs	Renames app state field from doctor_manager → examine_manager in tests.
crates/rocm-dash-tui/src/ui/mod.rs	Switches UI overlay wiring and footer label to examine.
crates/rocm-dash-tui/src/ui/logs_view.rs	Updates test comment referencing examine re-attach semantics.
crates/rocm-dash-tui/src/ui/examine_manager.rs	Introduces/updates examine overlay implementation and tests.
crates/rocm-dash-tui/src/ui/command_screen.rs	Updates examples/tests to use examine.
crates/rocm-dash-tui/src/app.rs	Renames overlay state/action plumbing to examine.
crates/rocm-core/src/lib.rs	Renames summary/inventory types and changes bridge snapshot field to examine.
apps/rocmd/src/lib.rs	Renames MCP tool to examine and updates snapshot/tool outputs and guards.
apps/rocm/src/tui.rs	Renames TUI surface/logic from doctor → examine, including tool routing and tests.
apps/rocm/src/providers.rs	Renames OpenAI tool definition references from doctor → examine.
apps/rocm/src/main.rs	Renames clap subcommand + internal rendering/planning/tool logic to examine.
.github/workflows/ci.yml	Updates CI host-detection step to run rocm.exe examine.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

apps/rocm/src/tui.rs:451

• If you keep doctor as a compatibility alias, is_examine_command_input should treat both examine and doctor as the same command; otherwise /doctor won't get the special-case behavior around background examine refresh blocking/deferral.

[volen-silo]

Review — clean, complete, mergeable

Reviewed the full diff. It's a disciplined pure rename; every change is a doctor→examine swap (locals, functions, enum variants, test names, status strings, the /doctor slash command + its completion tests, and the wire/tool renames). No logic or behavior change is mixed in.

Verified

• No stragglers — git grep -i doctor across source/docs/scripts/install returns zero hits outside the external rocm-doctor skill name.
• Internal wire consistency is compiler-guaranteed — the bridge snapshot key, SandboxToolArg::DoctorSnapshot→ExamineSnapshot, DoctorSummary→ExamineSummary, and the doctor_manager.rs→examine_manager.rs module are defined once in shared types, so a half-rename wouldn't compile. Builds + (renamed) tests pass.
• +796/−791 across 30 files — the signature of a rename with no net additions.

Advisory notes (non-blocking)

1. Hard break, no alias — sequencing matters most. rocm doctor now errors. That's fine in-repo, but the rocm-doctor skill in amd/skills shells out to rocm doctor, so it breaks the moment this ships until it's re-pointed at rocm examine. Recommend landing this in coordination with the skill update (and a heads-up to anyone with rocm doctor in scripts/CI).
2. Protocol/tool-name string renames (examine_snapshot, MCP tool "doctor"→"examine", bridge key) are safe in-repo but would break any external agent manifest hardcoding the old doctor tool name. Acceptable given rocmd-codex-bridge-v0 has no stability guarantee — just calling it out.
3. Renamed internal id strings in providers.rs (fallback-doctor → fallback-examine, etc.) — cosmetic unless any persisted state compares these id strings across versions. Almost certainly ephemeral; quick confirm would close it.
4. Nice-to-have: a one-line user-facing note (README/CHANGELOG) that doctor was renamed to examine with no alias, since it's a breaking CLI change.

Bottom line

Mechanically correct and complete. The only real consideration is merge sequencing with the skill so the catalog isn't calling a command that no longer exists.