Skip to content

[hpmicro][uart] Fix serial v2 putc return value#11517

Open
CYFS3 wants to merge 1 commit into
RT-Thread:masterfrom
CYFS3:fix/serial-putc-return-11392
Open

[hpmicro][uart] Fix serial v2 putc return value#11517
CYFS3 wants to merge 1 commit into
RT-Thread:masterfrom
CYFS3:fix/serial-putc-return-11392

Conversation

@CYFS3

@CYFS3 CYFS3 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Fixed #11392
修复 issue #11392。HPMicro 串口 V2 驱动的 hpm_uart_putc() 在发送成功后返回传入的 char 值;当发送中文等 UTF-8 数据时,高位字节在 char 为有符号类型的平台上会被解释为负值,进而被串口 V2 的 _serial_poll_tx() 判断为发送失败并提前中断,导致中文输出丢数据。

你的解决方案是什么 (what is your solution)

将 hpm_uart_putc() 的成功返回值由 ch 改为 1,表示已经成功发送 1 个字符,避免把合法的高位字节误判为负错误码。该返回语义也与 STM32 等串口 V2 驱动保持一致。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/hpmicro/hpm6750evk

  • .config: CONFIG_RT_USING_SERIAL_V2=y

  • action: 本地已执行 git diff --check;当前环境未安装 scons,未进行完整 BSP 编译。

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:fix/serial-putc-return-11392
  • 设置PR number为 \ Set the PR number to:11517
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 fix/serial-putc-return-11392 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/serial-putc-return-11392 branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added the BSP label Jun 26, 2026
@CYFS3 CYFS3 marked this pull request as ready for review June 26, 2026 02:42
@github-actions

Copy link
Copy Markdown

@CYFS3

CYFS3 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

另外应该要出个驱动相关适配的手册,规定正确的返回值等

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

1 participant