[components][pin.c]add rt_pin_get by yangjie11 · Pull Request #3863 · RT-Thread/rt-thread

yangjie11 · 2020-08-31T06:24:36Z

拉取/合并请求描述：(PR description)

[
PIN框架增加 rt_pin_get接口，
驱动已支持stm32，支持恩智浦lpc54114，
已在stm32l475/lpc54114上测试通过，
]

以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other style
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
本拉取/合并请求代码是高质量的 Code in this PR is of high quality

armink · 2020-08-31T06:31:32Z

    rt_err_t (*pin_detach_irq)(struct rt_device *device, rt_int32_t pin);
    rt_err_t (*pin_irq_enable)(struct rt_device *device, rt_base_t pin, rt_uint32_t enabled);
+
+    rt_base_t (*pin_get)(char *name);


const char*

BernardXiong · 2020-09-04T02:13:56Z

这样修改，需要连带着所有BSP都确认，并完成连带的修改

yangjie11 · 2020-09-07T07:38:30Z

好的，我确认了所有的BSP，drv_gpio驱动中的rt_pin_ops实例均是static类型，在初始化的时候会自动初始化为0，驱动可以不用做修改。但有一个BSP例外，我commit上来。

BernardXiong · 2020-09-10T00:46:05Z

涉及到 rt_pin_ops 的bsp包括：

allwinner_tina/drivers/drv_gpio.c:533:static const struct rt_pin_ops ops =
apollo2/board/gpio.c:207:const static struct rt_pin_ops am_pin_ops =
at32/Libraries/rt_drivers/drv_gpio.c:491:const static struct rt_pin_ops _at32_pin_ops =
beaglebone/drivers/gpio.c:82:static struct rt_pin_ops am33xx_pin_ops =
essemi/es32f0334/drivers/drv_gpio.c:403:const static struct rt_pin_ops _es32f0_pin_ops =
essemi/es32f369x/drivers/drv_gpio.c:403:const static struct rt_pin_ops _es32f3_pin_ops =
essemi/es32f0271/drivers/drv_gpio.c:445:const static struct rt_pin_ops _es32f0_pin_ops =
essemi/es8p508x/drivers/drv_gpio.c:377:const static struct rt_pin_ops _es8p_pin_ops =
essemi/es32f0654/drivers/drv_gpio.c:403:const static struct rt_pin_ops _es32f0_pin_ops =
gd32303e-eval/drivers/drv_gpio.c:492:const static struct rt_pin_ops _gd32_pin_ops =
gd32e230k-start/drivers/drv_gpio.c:383:const static struct rt_pin_ops _gd32_pin_ops =
gd32vf103v-eval/drivers/drv_gpio.c:422:const static struct rt_pin_ops _gd32vf_pin_ops =
imxrt/libraries/drivers/drv_gpio.c:583:const static struct rt_pin_ops imxrt_pin_ops =
imxrt/libraries/drivers/drv_gpio.c:597:    ret = rt_device_pin_register("pin", &imxrt_pin_ops, RT_NULL);
k210/driver/drv_gpio.c:246:const static struct rt_pin_ops drv_pin_ops =
lpc54114-lite/drivers/drv_gpio.c:284:const static struct rt_pin_ops _lpc_pin_ops =
lpc55sxx/Libraries/drivers/drv_pin.c:47:static struct rt_pin_ops lpc_pin_ops;
ls1cdev/drivers/drv_gpio.c:117:const static struct rt_pin_ops _ls1c_pin_ops =
ls2kdev/drivers/drv_gpio.c:215:static struct rt_pin_ops loongson_pin_ops = {
mm32l3xx/drivers/drv_gpio.c:404:const static struct rt_pin_ops _mm32_pin_ops =
nrf5x/libraries/drivers/drv_gpio.c:348:const static struct rt_pin_ops _nrf5x_pin_ops =
nuclei/libraries/gd32vf103/HAL_Drivers/drv_gpio.c:438:const static struct rt_pin_ops _gd32_pin_ops =
nuvoton/libraries/m480/rtt_port/drv_gpio.c:40:static struct rt_pin_ops nu_gpio_ops =
raspberry-pi/raspi3-64/driver/drv_gpio.c:290:static const struct rt_pin_ops ops =
raspberry-pi/raspi4-64/driver/drv_gpio.c:98:static const struct rt_pin_ops ops =
raspberry-pi/raspi3-32/driver/drv_gpio.c:289:static const struct rt_pin_ops ops =
raspberry-pi/raspi4-32/driver/drv_gpio.c:339:static const struct rt_pin_ops ops =
rv32m1_vega/ri5cy/driver/drv_gpio.c:491:static const struct rt_pin_ops vega_pin_ops =
stm32/libraries/HAL_Drivers/drv_gpio.c:641:const static struct rt_pin_ops _stm32_pin_ops =
swm320-lq100/drivers/drv_gpio.c:330:const static struct rt_pin_ops swm320_pin_ops =
tm4c123bsp/libraries/Drivers/drv_gpio.c:148:const static struct rt_pin_ops _tm4c123_pin_ops =
w60x/drivers/drv_pin.c:149:struct rt_pin_ops _wm_pin_ops =

请完成相关bsp修改。

Guozhanxin · 2020-09-10T02:16:50Z

涉及到 rt_pin_ops 的bsp包括：

allwinner_tina/drivers/drv_gpio.c:533:static const struct rt_pin_ops ops =
apollo2/board/gpio.c:207:const static struct rt_pin_ops am_pin_ops =
at32/Libraries/rt_drivers/drv_gpio.c:491:const static struct rt_pin_ops _at32_pin_ops =
beaglebone/drivers/gpio.c:82:static struct rt_pin_ops am33xx_pin_ops =
essemi/es32f0334/drivers/drv_gpio.c:403:const static struct rt_pin_ops _es32f0_pin_ops =
essemi/es32f369x/drivers/drv_gpio.c:403:const static struct rt_pin_ops _es32f3_pin_ops =
essemi/es32f0271/drivers/drv_gpio.c:445:const static struct rt_pin_ops _es32f0_pin_ops =
essemi/es8p508x/drivers/drv_gpio.c:377:const static struct rt_pin_ops _es8p_pin_ops =
essemi/es32f0654/drivers/drv_gpio.c:403:const static struct rt_pin_ops _es32f0_pin_ops =
gd32303e-eval/drivers/drv_gpio.c:492:const static struct rt_pin_ops _gd32_pin_ops =
gd32e230k-start/drivers/drv_gpio.c:383:const static struct rt_pin_ops _gd32_pin_ops =
gd32vf103v-eval/drivers/drv_gpio.c:422:const static struct rt_pin_ops _gd32vf_pin_ops =
imxrt/libraries/drivers/drv_gpio.c:583:const static struct rt_pin_ops imxrt_pin_ops =
imxrt/libraries/drivers/drv_gpio.c:597:    ret = rt_device_pin_register("pin", &imxrt_pin_ops, RT_NULL);
k210/driver/drv_gpio.c:246:const static struct rt_pin_ops drv_pin_ops =
lpc54114-lite/drivers/drv_gpio.c:284:const static struct rt_pin_ops _lpc_pin_ops =
lpc55sxx/Libraries/drivers/drv_pin.c:47:static struct rt_pin_ops lpc_pin_ops;
ls1cdev/drivers/drv_gpio.c:117:const static struct rt_pin_ops _ls1c_pin_ops =
ls2kdev/drivers/drv_gpio.c:215:static struct rt_pin_ops loongson_pin_ops = {
mm32l3xx/drivers/drv_gpio.c:404:const static struct rt_pin_ops _mm32_pin_ops =
nrf5x/libraries/drivers/drv_gpio.c:348:const static struct rt_pin_ops _nrf5x_pin_ops =
nuclei/libraries/gd32vf103/HAL_Drivers/drv_gpio.c:438:const static struct rt_pin_ops _gd32_pin_ops =
nuvoton/libraries/m480/rtt_port/drv_gpio.c:40:static struct rt_pin_ops nu_gpio_ops =
raspberry-pi/raspi3-64/driver/drv_gpio.c:290:static const struct rt_pin_ops ops =
raspberry-pi/raspi4-64/driver/drv_gpio.c:98:static const struct rt_pin_ops ops =
raspberry-pi/raspi3-32/driver/drv_gpio.c:289:static const struct rt_pin_ops ops =
raspberry-pi/raspi4-32/driver/drv_gpio.c:339:static const struct rt_pin_ops ops =
rv32m1_vega/ri5cy/driver/drv_gpio.c:491:static const struct rt_pin_ops vega_pin_ops =
stm32/libraries/HAL_Drivers/drv_gpio.c:641:const static struct rt_pin_ops _stm32_pin_ops =
swm320-lq100/drivers/drv_gpio.c:330:const static struct rt_pin_ops swm320_pin_ops =
tm4c123bsp/libraries/Drivers/drv_gpio.c:148:const static struct rt_pin_ops _tm4c123_pin_ops =
w60x/drivers/drv_pin.c:149:struct rt_pin_ops _wm_pin_ops =

请完整相关bsp修改。

@BernardXiong 意思是要把所有的 rt_pin_ops 都做相应的修改，赋值为 RT_NULL 吗？

可是这些变量都是 static 类型的，默认都是 0，不做处理应该也是一样的啊？

BernardXiong · 2020-09-11T00:41:13Z

涉及到 rt_pin_ops 的bsp包括：

allwinner_tina/drivers/drv_gpio.c:533:static const struct rt_pin_ops ops =
apollo2/board/gpio.c:207:const static struct rt_pin_ops am_pin_ops =
at32/Libraries/rt_drivers/drv_gpio.c:491:const static struct rt_pin_ops _at32_pin_ops =
beaglebone/drivers/gpio.c:82:static struct rt_pin_ops am33xx_pin_ops =
essemi/es32f0334/drivers/drv_gpio.c:403:const static struct rt_pin_ops _es32f0_pin_ops =
essemi/es32f369x/drivers/drv_gpio.c:403:const static struct rt_pin_ops _es32f3_pin_ops =
essemi/es32f0271/drivers/drv_gpio.c:445:const static struct rt_pin_ops _es32f0_pin_ops =
essemi/es8p508x/drivers/drv_gpio.c:377:const static struct rt_pin_ops _es8p_pin_ops =
essemi/es32f0654/drivers/drv_gpio.c:403:const static struct rt_pin_ops _es32f0_pin_ops =
gd32303e-eval/drivers/drv_gpio.c:492:const static struct rt_pin_ops _gd32_pin_ops =
gd32e230k-start/drivers/drv_gpio.c:383:const static struct rt_pin_ops _gd32_pin_ops =
gd32vf103v-eval/drivers/drv_gpio.c:422:const static struct rt_pin_ops _gd32vf_pin_ops =
imxrt/libraries/drivers/drv_gpio.c:583:const static struct rt_pin_ops imxrt_pin_ops =
imxrt/libraries/drivers/drv_gpio.c:597:    ret = rt_device_pin_register("pin", &imxrt_pin_ops, RT_NULL);
k210/driver/drv_gpio.c:246:const static struct rt_pin_ops drv_pin_ops =
lpc54114-lite/drivers/drv_gpio.c:284:const static struct rt_pin_ops _lpc_pin_ops =
lpc55sxx/Libraries/drivers/drv_pin.c:47:static struct rt_pin_ops lpc_pin_ops;
ls1cdev/drivers/drv_gpio.c:117:const static struct rt_pin_ops _ls1c_pin_ops =
ls2kdev/drivers/drv_gpio.c:215:static struct rt_pin_ops loongson_pin_ops = {
mm32l3xx/drivers/drv_gpio.c:404:const static struct rt_pin_ops _mm32_pin_ops =
nrf5x/libraries/drivers/drv_gpio.c:348:const static struct rt_pin_ops _nrf5x_pin_ops =
nuclei/libraries/gd32vf103/HAL_Drivers/drv_gpio.c:438:const static struct rt_pin_ops _gd32_pin_ops =
nuvoton/libraries/m480/rtt_port/drv_gpio.c:40:static struct rt_pin_ops nu_gpio_ops =
raspberry-pi/raspi3-64/driver/drv_gpio.c:290:static const struct rt_pin_ops ops =
raspberry-pi/raspi4-64/driver/drv_gpio.c:98:static const struct rt_pin_ops ops =
raspberry-pi/raspi3-32/driver/drv_gpio.c:289:static const struct rt_pin_ops ops =
raspberry-pi/raspi4-32/driver/drv_gpio.c:339:static const struct rt_pin_ops ops =
rv32m1_vega/ri5cy/driver/drv_gpio.c:491:static const struct rt_pin_ops vega_pin_ops =
stm32/libraries/HAL_Drivers/drv_gpio.c:641:const static struct rt_pin_ops _stm32_pin_ops =
swm320-lq100/drivers/drv_gpio.c:330:const static struct rt_pin_ops swm320_pin_ops =
tm4c123bsp/libraries/Drivers/drv_gpio.c:148:const static struct rt_pin_ops _tm4c123_pin_ops =
w60x/drivers/drv_pin.c:149:struct rt_pin_ops _wm_pin_ops =

请完整相关bsp修改。

@BernardXiong 意思是要把所有的 rt_pin_ops 都做相应的修改，赋值为 RT_NULL 吗？

可是这些变量都是 static 类型的，默认都是 0，不做处理应该也是一样的啊？

是的，都处理。

另外，不存侥幸心理，需要有明确的初始化。

yangjie11 · 2020-09-11T03:26:07Z

@BernardXiong 重新提了pr
#3897

yangjie11 added 3 commits August 31, 2020 14:02

[components][pin.c]add rt_pin_get

c45f48d

[bsp][stm32][drv_gpio.c]achieve ops pin_get

6c06afe

[bsp][lpc54114][drv_gpio.c]achieve ops pin_get

965f352

armink reviewed Aug 31, 2020

View reviewed changes

[components][pin]change the input parameter 'name' to const type.

b9e2020

yangjie11 added 2 commits September 7, 2020 15:40

[bsp][w60x]完善pin驱动中rt_pin_ops成员

92ec6af

[components][pin.c]对pin_get ops增加是否null的判断

6471821

[driver][pin]所有的rt_pin_ops初始化_pin_get

e1b8f96

yangjie11 closed this Sep 11, 2020

yangjie11 deleted the yj_dev branch November 20, 2020 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[components][pin.c]add rt_pin_get#3863

[components][pin.c]add rt_pin_get#3863
yangjie11 wants to merge 7 commits into
RT-Thread:masterfrom
yangjie11:yj_dev

yangjie11 commented Aug 31, 2020 •

edited

Loading

Uh oh!

armink Aug 31, 2020

Uh oh!

BernardXiong commented Sep 4, 2020

Uh oh!

yangjie11 commented Sep 7, 2020

Uh oh!

BernardXiong commented Sep 10, 2020 •

edited

Loading

Uh oh!

Guozhanxin commented Sep 10, 2020

Uh oh!

BernardXiong commented Sep 11, 2020

Uh oh!

yangjie11 commented Sep 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

yangjie11 commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

armink Aug 31, 2020

Choose a reason for hiding this comment

Uh oh!

BernardXiong commented Sep 4, 2020

Uh oh!

yangjie11 commented Sep 7, 2020

Uh oh!

BernardXiong commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Guozhanxin commented Sep 10, 2020

Uh oh!

BernardXiong commented Sep 11, 2020

Uh oh!

yangjie11 commented Sep 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yangjie11 commented Aug 31, 2020 •

edited

Loading

BernardXiong commented Sep 10, 2020 •

edited

Loading