[bsp][stm32] Remove RTC clock selection in board.c#5116
Closed
iysheng wants to merge 1 commit into
Closed
Conversation
Signed-off-by: iysheng <iysheng@163.com>
Member
Member
|
这样只能解决 board 里配置的 LSE,menuconfig里配置的LSI的问题。如果board里配置的LSI,RTC驱动里配置的LSE应该也会有问题。所以是不是最好的方式把RTC驱动里的时钟源切换的功能去掉,直接用board里的配置。如果要改的话,用cubemx改就好了 |
Member
|
改动有点大,下个版本再合吧 |
Contributor
|
ST新版本的HAL库,RTC时钟初始化,移了位置.是否是不匹配度致? |
Member
|
这个PR再攻一下,争取4.1.1处理一下,#4627 里 只剩下这个问题了 @Guozhanxin |
9 tasks
Closed
9 tasks
Member
Member
|
https://github.com/RT-Thread/rt-thread/blob/master/bsp/stm32/libraries/HAL_Drivers/drv_rtc.c#L230 可否直接改这里,换句话说 board.c里的RTC源并不重要,爱什么是什么,drv_rtc.c stm32_rtc_init初始化的时候根据用户选择的是BSP_RTC_USING_LSI来取判断外部时钟源还是内部时钟源 重新初始化时钟源 |
Member
|
https://github.com/RT-Thread/rt-thread/blob/master/bsp/stm32/libraries/HAL_Drivers/drv_rtc.c#L164 此处已经重新按照menuconfig 配置时钟,相似cubemx和menconfig配置出现冲突时,以menuconfig的配置为准,cubemx的时钟主要是为了设置系统的时钟源 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

拉取/合并请求描述:(PR description)
[
修复部分情况下通过 menuconfig 配置 stm32 平台 RTC 时钟源仍然会出现 RTC 初次获取时间戳提示未配置的问题
32f103 平台测试通过
涉及到的 issue #4627
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned updescription)