[stm32] move CMSIS hearder files to common folder#5998
Merged
Conversation
Member
|
如果没有特别大的提升,不建议这么修改,之前只是移除一部分cmsis的文件还好,这个pr相当于把cmsis分成了两部分,一部分系统统一管理,一部分各个库管理,还不在一个地方。容易给后期更新、维护造成困扰 |
1 similar comment
Member
|
如果没有特别大的提升,不建议这么修改,之前只是移除一部分cmsis的文件还好,这个pr相当于把cmsis分成了两部分,一部分系统统一管理,一部分各个库管理,还不在一个地方。容易给后期更新、维护造成困扰 |
Member
Author
|
现在有一些bsp一个BSP就含着一个CMSIS,CMSIS越来越多了。 |
Member
Author
|
后期维护不会出现过多困扰的,写一个说明文档就好了。现在为了维护偷懒 导致仓库里存了大量了无用、重复的文件 |
Member
|
这个改动非常好,我之前也觉得很多头文件很大(几M多),也重复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
将CMSIS头文件抽出来 统一放在STM32 libraries文件夹下,防止重复文件一轮叠一轮
已经测试通过无论是直接编译还是dist出来的工程都是没有问题的
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up