[scons][iar] sconscript rtconfig.py: CROSS_TOOL -> PLATFORM#6011
Merged
Conversation
因为不确定后续IAR是否会像Keil一样内含有不同的编译工具链 此外,将判断条件改为列表方式,这样更方便后续增加其他可能的IAR编译链
将路径更新为IAR最新版本的路径
Contributor
|
不错,顺便避免了 #5953 这个问题 |
Guozhanxin
approved these changes
May 31, 2022
Member
|
这个一些点上还是困扰的,因为PLATFORM也不是编译器的意思。或者应该是CC?CC = gcc | iar | armcc | armclang | etc... |
Member
Author
是的,这两个词实际上对于用户来说理解起来有些困扰,但是目前这个版本,不能改成CC,一旦改成CC软件包里的Sconscript也得改。这个改动得留到5.0.0. 目前这个PR只满足到4.1.1版本。 |
6 tasks
Member
|
至少这个pr应该没问题,要不这个就先合并了吧,要优化也是后面统一优化了 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
在判断编译器是应该使用PLATFROM字段而不是CROSS_TOOL字段,PLATFORM字段记录着该编译器当前所使用的编译工具链叫什么名字,而CROSS_TOOL只是IDE的名字。
使用CROSS_TOOL来判断当前的编译器工具链会出现很大的问题,比如Keil编译器,他的工具链有两个,如果直接用CROSS_TOOL == 'keil' 这种方式来判断是没有意义的,因此要是用PLATFORM in ['armcc', 'armclang']的方式
目前IAR还在使用CROSS_TOOL字段来判断,这样
在经过本PR修订之后,给出了明确的结论:
判断当前使用何种工具链一律使用PLATFROM字段,不使用CROSS_TOOL字段
related: #5802
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up