Skip to content

[bsp][stm32] 解决stm32l431-BearPi中spi挂载部分代码错误#6854

Closed
liYony wants to merge 3 commits into
RT-Thread:masterfrom
liYony:bearpi
Closed

[bsp][stm32] 解决stm32l431-BearPi中spi挂载部分代码错误#6854
liYony wants to merge 3 commits into
RT-Thread:masterfrom
liYony:bearpi

Conversation

@liYony

@liYony liYony commented Jan 14, 2023

Copy link
Copy Markdown
Contributor

拉取/合并请求描述：(PR description)

[
解决 https://github.com//pull/6819 这个pr的遗留问题。
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@BernardXiong BernardXiong added the +1 Agree +1 label Jan 14, 2023
@mysterywolf mysterywolf marked this pull request as draft January 14, 2023 04:01
@mysterywolf mysterywolf added the in progress PR/issue in progress. label Jan 14, 2023
mysterywolf
mysterywolf requested changes Jan 14, 2023
View reviewed changes
Comment thread bsp/stm32/stm32mp157a-st-ev1/board/ports/spi_sample.c
struct rt_spi_configuration cfg;

rt_hw_spi_device_attach(SPI_NAME, SPI_DEVICE_NAME, NULL, NULL);
rt_hw_spi_device_attach(SPI_NAME, SPI_DEVICE_NAME, RT_NULL);

@mysterywolf mysterywolf Jan 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RT_NULL 传进去 以目前的代码 要出问题

Comment thread bsp/stm32/stm32l496-ali-developer/board/ports/drv_spi_lcd.c
{
rt_hw_spi_device_attach("spi1", "spi10", GPIOA, GPIO_PIN_4);
struct rt_spi_configuration cfg;
cfg.cs_pin = GET_PIN(A, 4);

@mysterywolf mysterywolf Jan 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不能只赋值cfg成员变量，其他变量都是垃圾直

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mysterywolf mysterywolf mysterywolf requested changes
@BernardXiong BernardXiong BernardXiong approved these changes
@Rbb666 Rbb666 Awaiting requested review from Rbb666 Rbb666 will be requested when the pull request is marked ready for review Rbb666 is a code owner

Assignees

No one assigned

Labels

in progress PR/issue in progress. +1 Agree +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liYony @BernardXiong @mysterywolf