Skip to content

[qspi]修复qspi配置未生效问题#8528

Merged
mysterywolf merged 1 commit into
RT-Thread:masterfrom
yangpengya:fix_qspi
Feb 17, 2024
Merged

[qspi]修复qspi配置未生效问题#8528
mysterywolf merged 1 commit into
RT-Thread:masterfrom
yangpengya:fix_qspi

Conversation

@yangpengya

@yangpengya yangpengya commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#8527

你的解决方案是什么 (what is your solution)

将底层spi总线初始化功能独立出来,由spi或qspi配置函数直接调用,这样解决原来qspi配置更新但可能无法重新初始化的问题。

/* 底层spi总线初始化接口 */
rt_err_t rt_spi_bus_configure(struct rt_spi_device *device);

/* spi设备配置更新api. 
  如配置更新后需要重新初始化总线则直接调用rt_spi_bus_configure() */
rt_err_t rt_spi_configure(struct rt_spi_device *device, struct rt_spi_configuration *cfg);

/* qspi设备配置更新api. 
  如配置更新后需要重新初始化总线则直接调用rt_spi_bus_configure() */
rt_err_t rt_qspi_configure(struct rt_qspi_device *device, struct rt_qspi_configuration *cfg);

请提供验证的bsp和config (provide the config and bsp)

  • BSP:潘多拉开发板
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf

mysterywolf commented Feb 17, 2024

Copy link
Copy Markdown
Member

可以稍微详细描述一下这个PR的更改吗 尤其是rt_spi_bus_configure这个函数的增加,描述一下这个函数的使用场景,后续回溯写文档或者查询的时候会知道是怎么回事。

@mysterywolf mysterywolf merged commit 02eaf76 into RT-Thread:master Feb 17, 2024
@yangpengya yangpengya deleted the fix_qspi branch February 18, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

潘多拉开发板16M QSPI Flash只能使用前8M,无法使用后8M

2 participants