Merged
Conversation
SimonRit
force-pushed
the
external-cuda-common
branch
from
54a338e to
5333dbf
Compare
SimonRit
force-pushed
the
external-cuda-common
branch
3 times, most recently
from
e977054 to
c252faf
Compare
added 4 commits
March 23, 2023 10:43
Now builds with the remote module CudaCommon of ITK. Builds both as a remote module of ITK and as a standalone library. Co-authored by Alexy Pellegrini <alexy.pellegrini@kitware.com>
The Reg23ProjectionGeometry class has been kept for backward compatibility but will not be wrapped.
SimonRit
force-pushed
the
external-cuda-common
branch
from
c252faf to
ddaac34
Compare
Collaborator
Author
|
I think this is ready to be merged. Now that the CudaCommon packages have been uploaded to pypi, I tested the Python 3.9 version on Linux and Windows and it seems to work (FirstCudaReconstruction.py runs). Anything else I should test or do before merging? |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes and closes #492