Allow swiping on iOS 13 page sheet#124
Open
aheze wants to merge 1 commit into
Open
Conversation
Conform to gestureRecognizer(_:shouldBeRequiredToFailBy:) Details at https://developer.apple.com/documentation/uikit/uigesturerecognizerdelegate/1624222-gesturerecognizer
This was referenced Jul 7, 2020
|
+1 for this fix for those not wanting full screen presentation mode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conform to
gestureRecognizer(_:shouldBeRequiredToFailBy:).More technical details here.
Fixes issue 111 and also issue 116 (iOS 13 page sheet's built-in gesture conflicts with the swipe gesture). These issues are closed, but only a workaround was found (presenting the view controller in full screen). By returning
trueingestureRecognizer(_:shouldBeRequiredToFailBy:), you can present the view controller however you want.And even if you present via page sheet, both the built-in dismiss gesture and the swipe gesture work. Tested on iOS 13.5.1 and iPadOS 13.5.1.