Skip to content

ISelectable workspace property should be WorkspaceSvg #9214

@maribethb

Description

@maribethb

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

In the ISelectable interface, there is a workspace property that is type Workspace. It should really be of type WorkspaceSvg because it only makes sense in the context of rendered items (e.g. only BlockSvg implements ISelectable, Block doesn't). There are a lot of casts to WorkspaceSvg or unnecessary instanceof checks because of this.

Technically this is a breaking change because developer components could be using ISelectable so we should make this in v13.

Reproduction steps

Stack trace

Screenshots

No response

Browsers

No response

Metadata

Metadata

Assignees

Labels

breaking changeUsed to mark a PR or issue that changes our public APIs.issue: bugDescribes why the code or behaviour is wrong

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions