Add support for google closure library #207
Merged
NeilFraser merged 2 commits intoRaspberryPiFoundation:masterfrom Nov 14, 2015
Merged
Add support for google closure library #207NeilFraser merged 2 commits intoRaspberryPiFoundation:masterfrom
NeilFraser merged 2 commits intoRaspberryPiFoundation:masterfrom
Conversation
Update with main repository
When the closure library is installed by npm, it is named "google-closure-library", however it is named "closure-library" in build.py. When both blockly and closure are installed by npm, they are in the same folder so theoretically theoretically blockly should be able to build. Formatting and indentation might be a bit off as I edited this using the github editor.
This ```python
search_paths = calcdeps.ExpandDirectories(
["core", os.path.join(os.path.pardir, "closure-library")])
``` might need further revision to account for the additional naming. Maybe a try statement?
Contributor
There was a problem hiding this comment.
For this specific implementation, this check and the printed error are unnecessary, no?
Contributor
Author
There was a problem hiding this comment.
@carlosperate true, it is not necessary, you can remove it.
NeilFraser
added a commit
that referenced
this pull request
Nov 14, 2015
Add support for google closure library
mark-friedman
added a commit
to thunkable/blockly
that referenced
this pull request
Aug 29, 2017
This re-does RaspberryPiFoundation#207 directly on the Blockly source.
mark-friedman
added a commit
to thunkable/blockly
that referenced
this pull request
Aug 29, 2017
This re-does RaspberryPiFoundation#207 directly on the Blockly source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the closure library is installed by npm, it is named "google-closure-library", however it is named "closure-library" in build.py. When both blockly and closure are installed by npm, they are in the same folder so theoretically theoretically blockly should be able to build. Formatting and indentation might be a bit off as I edited this using the github editor.
This
python search_paths = calcdeps.ExpandDirectories( ["core", os.path.join(os.path.pardir, "closure-library")])might need further revision to account for the additional naming. Maybe a try statement?