fix: Fix bug that could cause focus to be lost in Chrome when dismissing a dropdown#9763
Merged
Conversation
mikeharv
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9759
Proposed Changes
This PR fixes a bug that caused focus to be lost/become passive on the element that spawned a dropdown when selecting an item in the dropdown or dismissing it on Chrome. This was because removal of elements from the DOM triggers
focusouton Chrome, but not on Firefox and Safari, due to an ambiguity in the spec. That has since been resolved, but Chrome has not (yet?) updated its behavior. I inverted the order of returning ephemeral focus and removing the dropdowndiv from the dom, so that focus will have already been returned before the div is removed, and thus even though that still fires afocusoutevent thereturnEphemeralFocushandler will have already been invoked and cleared by that point.