Macros expressing the intention behind casts to double. - #57
Closed
gareth-rees wants to merge 3 commits into
Closed
Conversation
gareth-rees
force-pushed
the
branch/2021-01-11/conversion-macros
branch
2 times, most recently
from
January 12, 2021 23:11
a4ce836 to
1d3989a
Compare
gareth-rees
force-pushed
the
branch/2021-01-11/conversion-macros
branch
from
January 12, 2021 23:11
1d3989a to
5e0ea7f
Compare
gareth-rees
marked this pull request as ready for review
January 15, 2021 13:26
…n preparation for review and merge and to get full CI builds.
rptb1
changed the base branch from
branch/2021-01-10/implicit-conversion
to
master
January 16, 2023 22:53
Member
|
The build fails on LII6LL with similar problems to #51 that were fixed in #52, so these macros seem to have regressed that fix. I can produce the same failure locally in Ubuntu clang version 14.0.0-1ubuntu1 at 5e0ea7f before the catch-up merge. |
…ing casts removed earlier in branch/2021-01-11/conversion-macros.
Member
Author
|
Let's just close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in review on #52, this pull request adds macros expressing the intention behind the casts to
(double)required to avoid warnings from Clang 10 with-Wimplicit-int-float-conversionon 64-bit platforms.