Skip to content

Fix up array overrun warnings on gcc 11.3.0 - #92

Merged
rptb1 merged 1 commit into
masterfrom
branch/2023-01-06/gcc-11.3.0-warnings
Jan 16, 2023
Merged

Fix up array overrun warnings on gcc 11.3.0#92
rptb1 merged 1 commit into
masterfrom
branch/2023-01-06/gcc-11.3.0-warnings

Conversation

@rptb1

@rptb1 rptb1 commented Jan 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Intended to resolve #114.

Specifies the shortened array in function prototypes to express intentions.

@rptb1 rptb1 self-assigned this Jan 6, 2023
@rptb1
rptb1 requested review from UNAA008 and thejayps January 6, 2023 17:57
gareth-rees
gareth-rees reviewed Jan 6, 2023
View reviewed changes
Comment thread code/poolams.c
Comment thread code/poolmvff.c
@rptb1 rptb1 mentioned this pull request Jan 14, 2023
Closed
@rptb1 rptb1 linked an issue Jan 14, 2023 that may be closed by this pull request
MPS does not build on gcc 11.3.0 due to warnings about potential array overruns #114
Closed
@rptb1 rptb1 changed the title MPS does not build on gcc 11.3.0 due to warnings about potential array overruns. Fix up array overrun warnings on gcc 11.3.0 Jan 14, 2023
@rptb1 rptb1 added build Problems with builds and build automation essential Will cause failure to meet customer requirements. Assign resources. labels Jan 15, 2023
thejayps
thejayps approved these changes Jan 16, 2023
View reviewed changes

@thejayps thejayps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no further comments to the existing review comments

@rptb1

rptb1 commented Jan 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Executing pull request merge procedure.

Checklist

  1. A test case for this would be whether the build is broken, and that is demonstrated by CI records. No test suite code is feasible.

@rptb1
rptb1 merged commit 5eacd32 into master Jan 16, 2023
rptb1 added a commit that referenced this pull request Mar 8, 2023
@rptb1
Merging branch/2023-01-06/gcc-11.3.0-warnings for GitHub pull request…
ee01a20 
… 92 <#92>.

(cherry picked from commit 5eacd32)

Extending the above to MV compatibility code for version 1.115.
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Sep 17, 2025
@rptb1
Merging branch/2023-01-06/gcc-11.3.0-warnings for github pull request…
209af03 
… 92 <Ravenbrook/mps#92>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gareth-rees gareth-rees gareth-rees left review comments
@thejayps thejayps thejayps approved these changes
@UNAA008 UNAA008 Awaiting requested review from UNAA008

Assignees

@rptb1 rptb1

Labels

build Problems with builds and build automation essential Will cause failure to meet customer requirements. Assign resources.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MPS does not build on gcc 11.3.0 due to warnings about potential array overruns

3 participants

@rptb1 @gareth-rees @thejayps