-
Notifications
You must be signed in to change notification settings - Fork 87
Fix and update the pull request merge procedure #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rptb1
merged 93 commits into
master
from
branch/2023-01-07/pull-request-merge-procedure
Jan 31, 2023
Merged
Changes from all commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
a6d2013
Comprehensive revision of pull request merge procedure after discussi…
rptb1 a2a9b21
Various fixes in response to review by GDR <https://github.com/Ravenb…
rptb1 c218301
Starting by cloning from GitHub, since this is now a strict superset …
rptb1 8d70e6f
Emphasizing that some things are in Perforce, because it wasn't immed…
rptb1 1c3538c
PNJ pointed out that trainee integrators (people who merge stuff) sho…
rptb1 d3c75ee
Adding reference to "GitHub Standard Fork & Pull Request Workflow".
rptb1 c1b8557
Fetching the branch to be merged directly to a local branch, removing…
rptb1 862f89b
Answering question about the GitHub merge button.
rptb1 a735ee6
PNJ points out that the Merge button in GitHUb, doing a fast-forward,…
rptb1 eb39f48
Validating RST and fixing minor issues.
rptb1 3e3aab9
Fixing the step for checking licensing of contributions.
rptb1 8e1984a
Improving RST formatting.
rptb1 3c784d7
Simplifying licensing of contributions by deeming them to conform to …
rptb1 071df18
Clarifying pre-merge checklist.
rptb1 2f557bd
Clear temporal separation of prerequisite steps. Further clarificati…
rptb1 304596d
Adding a step to create a "social lock" on the Perforce masters to av…
rptb1 4597f80
Fixing link markup.
rptb1 2074ee6
Comments become rationale in late-night rant.
rptb1 70f2ad7
Improving prerequisite wording.
rptb1 ce24be3
Adding an option step to push to GitHub promptly, and what to do if i…
rptb1 8bc60f6
Adding instructions for checking Travis CI results. This raises the …
rptb1 e4a6316
Explaining prerequisite checks for build results and what to do about…
rptb1 943b37c
Fixing RST validation errors.
rptb1 0072290
Clarifying that you can use your existing repo.
rptb1 dadbe3c
Moving licensing check to checklist to simplify main procedure.
rptb1 1af5368
Updating master first, so that problems with that are more likely to …
rptb1 9b35378
Correcting step cross-references.
rptb1 b55f048
Fixing typo.
rptb1 b296a5f
Fixing list markup.
rptb1 727a051
Adding reference to Git migration issue.
rptb1 cf6044c
Fixing numbered list markup.
rptb1 2ce5bf9
If there's a race on master we must back out our update. There might…
rptb1 8091ed7
Removing redundant branch name in push command.
rptb1 f46ce9e
Naming the Perforce Git Fusion remote "perforce" for clarity.
rptb1 7a6b309
Clarifying what replacing master achieves.
rptb1 311d91c
Pulling the branch to be merged directly from the PR ref at GitHub, r…
rptb1 ff70977
Simplifying the procedure by avoiding pushing via the local master, r…
rptb1 e56ec82
Updating old procedure section title inherited from [GDR_2014-01-09].
rptb1 9e381b7
Avoid renaming correctly named branches.
rptb1 6d131fc
Improving language and fixing a typo.
rptb1 94242f7
Adding note about [Chaser324_2017]_ being misleading about the Merge …
rptb1 6e954b3
Attempt to disable builds for this branch, branch/2023-01-07/pull-req…
rptb1 4182265
I was mislead by [Chaser324_2017]. Removed it and arguments from it.…
rptb1 784e8c6
Minor clarifications.
rptb1 de66514
Removing comment about customer-specific branches. This case is cove…
rptb1 fdd2a31
Adding reference to GitHub branch protection rules.
rptb1 7d4664a
Linking refs to GitHub repo for ease-of-use.
rptb1 4db501f
Removing draft status.
rptb1 eddd757
Adding link to pull request template docs.
rptb1 88d1502
Adding note about varying the procedure for pull requests not on GitHub.
rptb1 a27693d
Using Travis CI's "blocklisting" to exclude branches, rather than a c…
rptb1 b65abee
Adding instructions for the commit message on the merge.
rptb1 e509718
Attempt to prevent GitHub rewriting links to GitHub by using a code q…
rptb1 07194a2
Implementing a more natural strategy by separating the use of CI from…
rptb1 018cffb
Forgot to push to a fresh branch in the previous change.
rptb1 a4e2714
Adding instructions for the checklist.
rptb1 5fb61f0
Clarifying what to do if contributor varies licensing.
rptb1 39d148c
Adding step to configure Git email address.
rptb1 fd61b6d
Adding example command for when the branch is already in the Ravenbro…
rptb1 b6dbc22
Clarifying where to get the branch from and moving common case to top.
rptb1 84053a7
Explaining when to run tests.
rptb1 0de1cbd
Updating document history.
rptb1 f5cf908
Clarifying why we might pull from a pull request not a branch.
rptb1 68fffef
Clarifying what failure of pull might look like.
rptb1 576885a
Explaining why we edit the merge comment.
rptb1 1f313f5
Clarifying what "not having" CI results means.
rptb1 195de0b
Clarifying not to start the merging procedure when there are licensin…
rptb1 abb2243
Explaining more clearly where to find build results, and generalising…
rptb1 c54482f
Clarifying that "this procedure" in the checklist means the merging p…
rptb1 3992af2
Making it clearer how to do a fetch from a pull request by number.
rptb1 0a08f82
Further generalisation of CI to include both Travis and GitHub.
rptb1 8a3d0d8
Fixing typo <https://github.com/Ravenbrook/mps/pull/97#discussion_r10…
rptb1 52c1d3a
More neutral wording about fast-forwards and squashes, suggested in <…
rptb1 88b3796
Adding check for approval in response to <https://github.com/Ravenbro…
rptb1 95e918d
Updating document history with references back to GitHub conversations.
rptb1 a694da2
Stating purpose of procedure in response to <https://github.com/Raven…
rptb1 f90c65f
Adding more thorough check that Perforce is in sync with GitHub in re…
rptb1 6573ba6
Unifying and simplifying checklist item for build results in response…
rptb1 c22a00b
Clarifying that local/CI build step conditions are the same, in respo…
rptb1 fe8ce04
Short explanation of basis for deciding after checklist, in response …
rptb1 8f4e0ac
Unfortunately, inserting this reference resets the numbered list. Ba…
rptb1 94dddf5
Explaining where to look for build results in step 6.
rptb1 fe8851f
Linking justification of durable branch naming convention. Adding st…
rptb1 99ff0d0
Process improvement: check that the code review is recent. Response …
rptb1 5fd7891
Adding instruction to record the revision of the procedure being foll…
rptb1 24f80d7
Adding document tag proc.merge.pull-request.
rptb1 a9ce80c
Adding time-to-execute estimates based on measurements.
rptb1 6fd5a3d
Clarifying what "interface" means, in response to comment by @UNAA008…
rptb1 3dde051
Clarifying levels of competence needed and risks of executing the pro…
rptb1 c2472d8
Fixing heading markup of subsection headings in section 6.
rptb1 973fc08
Clarifying what I mean by "basic competence with Git".
rptb1 b0110bb
Adding instructions for recording the merge.
rptb1 e36c8f9
Fixing git command for pushing a fresh CI branch.
rptb1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.