Skip to content

Parse hyphenated quoted symbols #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singaraiona merged 2 commits into from
Jun 30, 2026
Merged

Parse hyphenated quoted symbols #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f018070
Merge pull request #291 from RayforceDB/dev
singaraiona Jun 24, 2026
0ab89ca
parse hyphenated quoted symbols
theaspirational Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lang/parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,8 @@ static ray_t* parse_symbol(ray_parser_t *p) {
}

/* Regular symbol */
while (PA(*p->pos) == PA_ALPHA || PA(*p->pos) == PA_DIGIT || *p->pos == '_' || *p->pos == '.')
while (PA(*p->pos) == PA_ALPHA || PA(*p->pos) == PA_DIGIT
|| *p->pos == '_' || *p->pos == '.' || *p->pos == '-')
p->pos++;
size_t len = (size_t)(p->pos - start);
int64_t id = (len == 0) ? 0 : ray_sym_intern(start, len); /* empty symbol — sym 0 */
Expand Down
1 change: 0 additions & 1 deletion test/rfl/cmp/gt.rfl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
(> ['b 'b 'b] ['a 'b 'c]) -- [true false false]

;; mixed inline (≤ 12 bytes) and pooled (> 12 bytes) — exercises SSO.
;; Note: hyphens in symbols would be parsed as ops, so use underscore.
;; 's' > 'l' so 'short > 'longer_…
(> 'short 'longer_than_twelve_bytes_symbol) -- true
(> 'longer_than_twelve_bytes_symbol 'short) -- false
Expand Down
3 changes: 3 additions & 0 deletions test/rfl/lang/parse_branch_cov.rfl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,9 @@
;; dotted / underscored symbol chars (parse_symbol loop :456)
(as 'STR 'a.b.c) -- "a.b.c"
(as 'STR 'a_b) -- "a_b"
;; hyphenated quoted symbol chars match the documented symbol syntax
(as 'STR 'a-b) -- "a-b"
(== 'a-b 'a-b) -- true
;; empty symbol before a closing bracket / brace / paren
;; (parse_symbol terminator guard :408-409)
(count (list ')) -- 1
Expand Down
Loading