Skip to content

Allow constructing RMatrix from a non-const buffer #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinushey merged 2 commits into from
Dec 4, 2020
Merged

Allow constructing RMatrix from a non-const buffer #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4db743
Allow constructing RMatrix from a non-const buffer
galexv Dec 3, 2020
d8fc414
Corrected a signed-unsigned comparison warning
galexv Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/include/RcppParallel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ inline void parallelFor(std::size_t begin,
std::size_t grainSize = 1,
int numThreads = -1)
{
grainSize = resolveValue("RCPP_PARALLEL_GRAIN_SIZE", grainSize, 1);
grainSize = resolveValue("RCPP_PARALLEL_GRAIN_SIZE", grainSize, 1u);
numThreads = resolveValue("RCPP_PARALLEL_NUM_THREADS", numThreads, -1);

#if RCPP_PARALLEL_USE_TBB
Expand Down
2 changes: 1 addition & 1 deletion inst/include/RcppParallel/RMatrix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ class RMatrix {
{
}

inline RMatrix(const T* data, std::size_t nrow, std::size_t ncol)
inline RMatrix(T* data, std::size_t nrow, std::size_t ncol)
: data_(data), nrow_(nrow), ncol_(ncol)
{
}
Expand Down