Check if there is internal ref to prevent calling getBoundingClientRect on undefined.#622
Closed
Baael wants to merge 5 commits intoReactTooltip:masterfrom
Closed
Check if there is internal ref to prevent calling getBoundingClientRect on undefined.#622Baael wants to merge 5 commits intoReactTooltip:masterfrom
Baael wants to merge 5 commits intoReactTooltip:masterfrom
Conversation
…er-scroll fix: prevent tooltip action when there is no ref element
chore: build script in prepare to allows us to use github install
|
Hey @Baael, I'm having the issue this is meant to fix. Would love if your fix got merged. Just curious why this was closed? Thank you for investigating a fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library is trying to call
getBoundingClientRecton undefined. Can be reproduces with use ofevent="mousedown mouseenter".May be related to #531 and few other issues.