fix(style injection): change style injection default root#666
Merged
roggervalf merged 1 commit intoReactTooltip:masterfrom Jan 14, 2021
janeksmielowski:fix-styles-injection
Merged
fix(style injection): change style injection default root#666roggervalf merged 1 commit intoReactTooltip:masterfrom janeksmielowski:fix-styles-injection
roggervalf merged 1 commit intoReactTooltip:masterfrom
janeksmielowski:fix-styles-injection
Conversation
Change style injection root to evaluated parent node, that should equal to nearest shadow root host, otherwise use head fix #665
roggervalf
approved these changes
Jan 14, 2021
Contributor
roggervalf
left a comment
roggervalf
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change style injection root to evaluated parent node, that should equal to nearest shadow root host,
otherwise use head
fix #665