Skip to content

fix(compability): add polyfill and change styles #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roggervalf merged 1 commit into from
May 28, 2021
Merged

fix(compability): add polyfill and change styles #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@
"@babel/plugin-proposal-json-strings"
],
"presets": [
"@babel/preset-env",
[
"@babel/preset-env",
{
"useBuiltIns": "entry",
"corejs": "3.12"
}
],
"@babel/preset-react"
]
}
}
2 changes: 1 addition & 1 deletion bin/transferSass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const sass = require('node-sass');
const sass = require('sass');
const fs = require('fs');
const path = require('path');

Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
"chai-spies": "^1.0.0",
"commitizen": "2.9.6",
"concurrently": "^2.1.0",
"core-js": "^3.12.1",
"cpy-cli": "^3.1.1",
"cz-conventional-changelog": "^3.1.0",
"enzyme": "^2.3.0",
Expand All @@ -114,7 +115,6 @@
"mocha": "^8.1.3",
"mocha-each": "^2.0.1",
"mocha-jsdom": "^2.0.0",
"node-sass": "^4.13.1",
"npm-run-all": "^4.1.5",
"postcss-nested": "^4.2.1",
"postcss-simple-vars": "^5.0.2",
Expand All @@ -132,6 +132,7 @@
"rollup-plugin-sass": "^1.2.2",
"rollup-plugin-stylelint": "1.0.0",
"rollup-plugin-url": "^3.0.1",
"sass": "^1.34.0",
Copy link
Copy Markdown
Contributor

@roggervalf roggervalf May 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why do we need to change node-sass with sass package here?

Copy link
Copy Markdown
Contributor Author

@243083df 243083df May 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because old node-sass not compile correctly on windows 10 D: (and node-sass depreacted since 26 October 2020)
But I compared, compiled css not changed.

It not crucial for ie11 support, so i do not insist to add this change.

Copy link
Copy Markdown
Contributor

@roggervalf roggervalf May 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @243083df, lgtm

"semantic-release": "^17.0.4",
"snazzy": "^2.0.1",
"standard": "^5.2.2",
Expand Down
4 changes: 4 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ import { generateUUID } from './utils/uuid';
import baseCss from './index.scss';
import { generateTooltipStyle } from './decorators/styler';

/* Polyfill */
import 'core-js/modules/es.array.find';

@staticMethods
@windowListener
@customEvent
Expand Down Expand Up @@ -191,6 +194,7 @@ class ReactTooltip extends React.Component {
switch (parentNode.constructor.name) {
case 'Document':
case 'HTMLDocument':
case undefined:
domRoot = parentNode.head;
break;
case 'ShadowRoot':
Expand Down
Loading