fix: return 403 Forbidden for unauthorized extension request updates#230
Merged
Conversation
Summary by CodeRabbit
WalkthroughThis pull request updates the error handling for the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant S as API Server
C->>S: PATCH /extension-requests/:id
S->>S: Verify user permissions
alt Insufficient permissions
S-->>C: 403 Forbidden (JSON with details)
else Sufficient permissions
S-->>C: Proceed with update (not shown)
end
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
10 tasks
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
pankajjs
approved these changes
Apr 3, 2025
Achintya-Chatterjee
approved these changes
Apr 4, 2025
tejaskh3
reviewed
Apr 5, 2025
|
|
||
| - **Error Response:** | ||
| - **Code** 403 | ||
| - **Content** `{ 'statusCode': 403, 'error': 'Forbidden', 'message': 'You don't have permission to update the extension request' }` |
Contributor
There was a problem hiding this comment.
again, I think the error messsage should be changed
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion! I believe the original message is more appropriate here since it's about permissions, not missing content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date: 3 April 2025
Developer Name: @AnujChhikara
Issue Ticket Number
Description
This PR updates the PATCH /extension-requests/:id API contract by adding a 403 Forbidden response
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes