*WIP* Add: cypress tests setup#276
Merged
Merged
Conversation
| }, | ||
| "rules": { | ||
| "linebreak-style": ["warn", "unix"], | ||
| "no-unused-vars": "warn", |
Contributor
There was a problem hiding this comment.
Should we not consider this as 'error' or 2?
Contributor
Author
There was a problem hiding this comment.
Sorry I didn't get you here.
Contributor
|
@MehulKChaudhari excellent work on setting up MSW, but I couldn't find it as devDependencies or dependencies in package.json. NIT: Can we separate the MSW setup into other PR, Also lets move to yarn and start using volta to pin node versions |
Contributor
Author
Sure |
Merged
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MehulKChaudhari
changed the title
prakashchoudhary07
previously approved these changes
Dec 4, 2022
shubham-y
approved these changes
Dec 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add end-to-end test and jest setup to the Repo.