FEAT: added dropdown with sign-out option in navbar by kotesh-arya · Pull Request #290 · RealDevSquad/website-crypto

kotesh-arya · 2022-10-14T10:33:35Z

Closes #284

Description

Currently, When the user visits the RDS website, they sign in with Git hub but are unable to sign out. This feature will enable them to sign out by providing them with an option to sign out in a dropdown from the navbar, as shown below:

vinayak-trivedi

Thanks for the PR @kotesh-arya
I've requested some changes, please have a look at them

Muralidhar22

I think the dropdown css file name can be given as dropdown.module.css, is there any reason it's named as s.module.css . what do you think?

kotesh-arya · 2022-10-19T11:46:03Z

I agree with you @Muralidhar22 , but I am using the styled-jsx now and I will consider naming files more meaningfully 👍🏻

Maheima · 2022-11-18T12:54:29Z

I think you should add the functionality where the dropdown closes when a user clicks outside of it too

MehulKChaudhari · 2022-11-18T12:55:24Z

I think you should add the functionality where the dropdown closes when a user clicks outside of it too

+1

kotesh-arya · 2022-11-19T12:19:35Z

I think you should add the functionality where the dropdown closes when a user clicks outside of it too

Added it @Maheima 👍🏻

SanketDhabarde · 2022-12-01T15:14:34Z

I think you should add the functionality where the dropdown closes when a user clicks outside of it too

Added it @Maheima 👍🏻

So @kotesh-arya will it close the dropdown when clicking on the navbar or anywhere on screen?

Maheima

LGTM!

vinayak-trivedi

LGTM 👍

kotesh-arya · 2022-12-04T11:24:41Z

I think you should add the functionality where the dropdown closes when a user clicks outside of it too

Added it @Maheima 👍🏻

So @kotesh-arya will it close the dropdown when clicking on the navbar or anywhere on screen?

Yes @SanketDhabarde !
It will close even if user clicks anywhere on the page 👍🏻

MehulKChaudhari

Great move 🔥 using redux. Added few comments please check.

Maheima

LGTM!

vercel · 2022-12-22T09:50:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
website-crypto	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Jan 24, 2023 at 7:34AM (UTC)

…rypto into feature/sign-out-option

ivinayakg

Great Job 👍

FEAT: added dropdown with signout option in navbar

8664e46

vinayak-trivedi suggested changes Oct 18, 2022

View reviewed changes

Comment thread components/dropdown/index.js Outdated

Comment thread components/dropdown/index.js Outdated

Comment thread components/dropdown/index.js Outdated

Comment thread components/dropdown/s.module.css

Muralidhar22 reviewed Oct 18, 2022

View reviewed changes

STYLES: Updated module-styling to styled-jsx

4a00615

vinayak-trivedi reviewed Oct 25, 2022

View reviewed changes

Comment thread components/dropdown/index.js Outdated

Comment thread components/dropdown/index.js Outdated

REFACTOR: moved signout function to utils

136403c

vinayak-trivedi reviewed Oct 26, 2022

View reviewed changes

Comment thread components/NavBar/index.js

Comment thread package.json Outdated

REFACTOR: handled no User-profile case

19f7665

Maheima suggested changes Nov 1, 2022

View reviewed changes

Comment thread color/color.json

CHORE: removed spaces

fd28413

vinayak-trivedi reviewed Nov 2, 2022

View reviewed changes

Comment thread color/color.json Outdated

vinayak-trivedi reviewed Nov 2, 2022

View reviewed changes

Comment thread components/NavBar/index.js Outdated

vinayak-trivedi reviewed Nov 2, 2022

View reviewed changes

Comment thread components/dropdown/index.js Outdated

CHORES: remove white spaces

993e31c

SanketDhabarde reviewed Nov 3, 2022

View reviewed changes

Comment thread components/dropdown/index.js Outdated

SanketDhabarde reviewed Nov 3, 2022

View reviewed changes

Comment thread components/NavBar/navbar.module.css

REFACTOR: abstract signout function

a85b49a

FEAT: dropdown closes on-clicking outside

0238174

Muralidhar22 reviewed Nov 24, 2022

View reviewed changes

Comment thread components/NavBar/index.js

Muralidhar22 previously approved these changes Nov 25, 2022

View reviewed changes

Maheima previously approved these changes Dec 1, 2022

View reviewed changes

vinayak-trivedi previously approved these changes Dec 2, 2022

View reviewed changes

UPDATE: dropdown toggling

6b2b46e

kotesh-arya dismissed stale reviews from vinayak-trivedi and Maheima via 6b2b46e December 4, 2022 11:22

kotesh-arya dismissed Muralidhar22’s stale review via 6b2b46e December 4, 2022 11:22

SanketDhabarde reviewed Dec 6, 2022

View reviewed changes

Comment thread redux/reducers/dropdowntoggle.js

MehulKChaudhari suggested changes Dec 6, 2022

View reviewed changes

Comment thread components/NavBar/index.js Outdated

Comment thread components/dropdown/index.js Outdated

Maheima previously approved these changes Dec 7, 2022

View reviewed changes

REFACTOR: Dropdowndispatchtoggle logic refactored

69d169d

kotesh-arya dismissed Maheima’s stale review via 69d169d December 22, 2022 09:50

vercel Bot deployed to Preview December 22, 2022 09:51 View deployment

kotesh-arya added 4 commits December 30, 2022 15:38

STYLES: changed dropdown styling to modular

5d08148

Merge branch 'develop' of https://github.com/Real-Dev-Squad/website-c…

46362ff

…rypto into feature/sign-out-option

UPDATE: cypress latest version

c00a7da

STYLES: Updated colours

feef13c

vercel Bot deployed to Preview January 24, 2023 07:34 View deployment

ivinayakg approved these changes Feb 1, 2023

View reviewed changes

MehulKChaudhari approved these changes Feb 10, 2023

View reviewed changes

MehulKChaudhari merged commit 46c0000 into RealDevSquad:develop Feb 10, 2023

MehulKChaudhari assigned kotesh-arya Feb 10, 2023

Uh oh!

Conversation

kotesh-arya commented Oct 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinayak-trivedi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Muralidhar22 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kotesh-arya commented Oct 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Maheima commented Nov 18, 2022

Uh oh!

MehulKChaudhari commented Nov 18, 2022

Uh oh!

kotesh-arya commented Nov 19, 2022

Uh oh!

Uh oh!

SanketDhabarde commented Dec 1, 2022

Uh oh!

Maheima left a comment

Choose a reason for hiding this comment

Uh oh!

vinayak-trivedi left a comment

Choose a reason for hiding this comment

Uh oh!

kotesh-arya commented Dec 4, 2022

Uh oh!

Uh oh!

MehulKChaudhari left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Maheima left a comment

Choose a reason for hiding this comment

Uh oh!

vercel Bot commented Dec 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivinayakg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kotesh-arya commented Oct 14, 2022 •

edited

Loading

Muralidhar22 left a comment •

edited

Loading

vercel Bot commented Dec 22, 2022 •

edited

Loading