Skip to content

upgrade the node, nextjs and react version - #309

Merged
iamitprakash merged 5 commits into
developfrom
fix/upgrade-node-next-react
Oct 14, 2023
Merged

upgrade the node, nextjs and react version#309
iamitprakash merged 5 commits into
developfrom
fix/upgrade-node-next-react

Conversation

@RitikJaiswal75

@RitikJaiswal75 RitikJaiswal75 commented Oct 14, 2023

Copy link
Copy Markdown
Contributor

This PR upgrades the versions of the dependencies

Package previous version new version
Node 14 18
next 10 13
react 17 18
react dom 17 18

Note

In multiple Link tags you will fing a legacy behaviour attribute as on implementing next 13 we can not use anchor tah inside link tags. Since this PR just deals with the version upgrades thus i am not adding any major code changes to it.

Warning

Currently the deployments via vercel are failing, we do expect them to fail as well as in the current scenario we are not making the crypto site public. We do not plan to make it public yet.

Visuals of Site working

Screencast.from.2023-10-15.02-35-02.mp4

Closes: #310

@vercel

vercel Bot commented Oct 14, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-crypto ❌ Failed (Inspect) Oct 14, 2023 8:46pm

@RitikJaiswal75 RitikJaiswal75 self-assigned this Oct 14, 2023

@iamitprakash iamitprakash left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please help me the reason to upgrade and why this particular one, any ticket in place, along with regression test proof like because of version dependency nothing is/are breaking at runtime

@RitikJaiswal75

Copy link
Copy Markdown
Contributor Author

can you please help me the reason to upgrade and why this partical one, ant ticket in place, along with regression test proof like because of version dependency nothing is/are breaking at runtime

I have upgraded from node 14 to node 18 as per discussion with @ankushdharkar to keep the project compatible with upcoming versions.

Same goes for upgrading from next 10 to next 13

Since i upgraded to next 13 it is mandatory to update to react 18

@iamitprakash

Copy link
Copy Markdown
Member

can you please help me the reason to upgrade and why this partical one, ant ticket in place, along with regression test proof like because of version dependency nothing is/are breaking at runtime

I have upgraded from node 14 to node 18 as per discussion with @ankushdharkar to keep the project compatible with upcoming versions.

Same goes for upgrading from next 10 to next 13

Since i upgraded to next 13 it is mandatory to update to react 18

please add this in ticket and FW to me and build is failing as well, TEST proof is needed

@iamitprakash iamitprakash left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is index.js file change is part of version upgrade ..?

@RitikJaiswal75

Copy link
Copy Markdown
Contributor Author

is index.js file change is part of version upgrade ..?

Explained it as a note provided over the main comment

@iamitprakash

Copy link
Copy Markdown
Member

is index.js file change is part of version upgrade ..?

Explained it as a note provided over the main comment

All details should be in separate task/issues ticket

@RitikJaiswal75

Copy link
Copy Markdown
Contributor Author

please add this in ticket and FW to me and build is failing as well, TEST proof is needed

This is the spike ticket where i will be researching and making future updates to the project: #308

@iamitprakash

Copy link
Copy Markdown
Member

please add this in ticket and FW to me and build is failing as well, TEST proof is needed

This is the spike ticket where i will be researching and making future updates to the project: #308

renamed as [POC] as things are not clear in CI, please keep updating as progress in investigation

@RitikJaiswal75

Copy link
Copy Markdown
Contributor Author

is index.js file change is part of version upgrade ..?

Explained it as a note provided over the main comment

All details should be in separate task/issues ticket

could you please elaborate on this

@iamitprakash

Copy link
Copy Markdown
Member

is index.js file change is part of version upgrade ..?

Explained it as a note provided over the main comment

All details should be in separate task/issues ticket

could you please elaborate on this

plane english

@RitikJaiswal75

Copy link
Copy Markdown
Contributor Author

plane english

I still could not get you

@iamitprakash
iamitprakash merged commit d91a74f into develop Oct 14, 2023
@iamitprakash
iamitprakash deleted the fix/upgrade-node-next-react branch October 14, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Node and Next.js Versions for Crypto-Site

2 participants