Signup landing page for new users by sumitd94 · Pull Request #78 · RealDevSquad/website-my

sumitd94 · 2021-04-09T20:42:26Z

This PR fixes issue #70

the signup page can be accessed at /signup?state=get-started

Desktop view

Mobile view - iPhone 5/SE

iPad

swarajpure

I thought we were going to have screens which ask for first name, last name and username after we click on Get Started 🤔
Or is it not so?

sumitd94 · 2021-04-18T07:54:30Z

I thought we were going to have screens which ask for first name, last name and username after we click on Get Started 🤔
Or is it not so?

Not sure about those, we need to ask @ankushdharkar about that. When the user signs up using GitHub, we will be redirecting them to this page, and when they click on the get-started button, will take them to the signup form.

swarajpure · 2021-04-18T14:46:31Z

I thought we were going to have screens which ask for first name, last name and username after we click on Get Started thinking
Or is it not so?

Not sure about those, we need to ask @ankushdharkar about that. When the user signs up using GitHub, we will be redirecting them to this page, and when they click on the get-started button, will take them to the signup form.

The design link is there in the issue description itself 😅

akankshadharkar

Left a few comments
Also, I think we should change the filename from "form-input" to maybe "signup-form" since the current file doesn't contain just an input but the whole form

akankshadharkar

Thanks for addressing the previous comments, Sumit
Left a couple more
Rest lgtm 😄

addressed

takshch

Component name sign-up/signup-form is redundant. Please replace it with sign-up/form

swarajpure

Some doubts, please check!

swarajpure · 2021-06-21T19:49:38Z

+  {{#if (eq this.state "get-started")}}
+    <SignUp::GetStarted
+      @changeRouteParams={{this.changeRouteParams}}
+      @state={{this.state}}
+    />
+  {{else if (eq this.state "thank-you")}}
+    <SignUp::GetStarted
+      @changeRouteParams={{this.changeRouteParams}}
+      @state={{this.state}}
+    />


What are these if and else doing differently? 🤔

I want to render this component if the value of state is either get-started or thank-you.
But I am not able to find how to use the condition - if (state = 'get-started' || state = 'thank-you') in ember. And so I am rendering like this

We're already using ember-truth-helpers in our project
Refering this might help: https://www.npmjs.com/package/ember-truth-helpers/v/2.1.0#usage

Already tried this. But it's not working.

…ite-my into landing-page

takshch · 2021-07-07T08:00:26Z

+    if (paramValue)
+      this.transitionToRoute({ queryParams: { state: paramValue } });


Use router service because this.transitionToRoute is deprecated.
https://deprecations.emberjs.com/v3.x/#toc_routing-transition-methods

swarajpure · 2021-08-08T10:37:42Z

-
-    if (response.status === 401) {
+    if (response.status == 200 && !userData.incompleteUserDetails) {
+      alert("You already have filled the up form. You'll now be redirected.");


NIT: single quotes please?

sumitd94 · 2021-09-06T13:53:41Z

#143 closing this PR because it's messed up so much!

sumitd94 added 2 commits April 10, 2021 02:00

Create a landing page

4706c4e

Change the route name

b0f8148

sumitd94 requested review from SagarBajpai, akankshadharkar, ankushdharkar and swarajpure April 9, 2021 20:42

Change the media query max-width

be4436b

harshith-venkatesh previously approved these changes Apr 9, 2021

View reviewed changes

Comment thread app/styles/landing.css Outdated

swarajpure reviewed Apr 10, 2021

View reviewed changes

Comment thread app/components/landing.hbs Outdated

Change font unit to rem

e823a79

sumitd94 dismissed harshith-venkatesh’s stale review via e823a79 April 11, 2021 16:05

Name classes according to BEM

8780fca

sumitd94 requested review from harshith-venkatesh and swarajpure April 11, 2021 16:55

harshith-venkatesh previously approved these changes Apr 11, 2021

View reviewed changes

Comment thread app/styles/landing.css Outdated

swarajpure reviewed Apr 13, 2021

View reviewed changes

Change px to rem for padding

c513d23

sumitd94 dismissed harshith-venkatesh’s stale review via c513d23 April 18, 2021 08:09

sumitd94 force-pushed the landing-page branch from 7f043e5 to c513d23 Compare April 18, 2021 08:09

Merge branch 'develop' into landing-page

443f0ed

sumitd94 requested review from harshith-venkatesh and swarajpure April 18, 2021 08:10

harshith-venkatesh previously approved these changes Apr 18, 2021

View reviewed changes

swarajpure mentioned this pull request Apr 27, 2021

Create UI for clearing cache #84

Open

sumitd94 added 2 commits May 13, 2021 17:40

Feature: SignUp flow

6f1a96f

Feature: SignUp flow

13e9dff

sumitd94 dismissed harshith-venkatesh’s stale review via 13e9dff May 13, 2021 12:30

sumitd94 requested a review from harshith-venkatesh May 13, 2021 12:32

akankshadharkar previously requested changes May 13, 2021

View reviewed changes

Refactor signup process

075a915

akankshadharkar reviewed May 18, 2021

View reviewed changes

sumitd94 added 2 commits June 5, 2021 21:24

Refactor code

8c093d9

Fix the prettier issue

ff9cf44

sumitd94 requested a review from akankshadharkar June 5, 2021 16:00

Remove test for form-input

317c1cb

sumitd94 mentioned this pull request Jun 12, 2021

Add query param for signup page RealDevSquad/website-www#118

Merged

takshch suggested changes Jun 12, 2021

View reviewed changes

code refactor

62acb2b

sumitd94 force-pushed the landing-page branch from dc92f10 to 62acb2b Compare June 20, 2021 15:04

Merge branch 'develop' into landing-page

8c03c79

swarajpure reviewed Jun 21, 2021

View reviewed changes

sumitd94 added 3 commits June 22, 2021 21:33

remove default value for user

4ecc82a

Merge branch 'landing-page' of https://github.com/Real-Dev-Squad/webs…

8069bcf

…ite-my into landing-page

Add constants file and rename form component

186e4c8

takshch suggested changes Jul 7, 2021

View reviewed changes

ankushdharkar assigned sumitd94 Jul 27, 2021

ankushdharkar removed request for akankshadharkar and harshith-venkatesh July 27, 2021 16:23

ankushdharkar added the feature task A big ticket item that needs to come up as a feature label Jul 27, 2021

swarajpure suggested changes Aug 8, 2021

View reviewed changes

ankushdharkar changed the title ~~Landing page for new users~~ Signup landing page for new users Aug 13, 2021

sumitd94 force-pushed the landing-page branch from 5bc0497 to 186e4c8 Compare September 6, 2021 13:14

sumitd94 closed this Sep 6, 2021

		if (paramValue)
		this.transitionToRoute({ queryParams: { state: paramValue } });

Uh oh!

Conversation

sumitd94 commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

swarajpure left a comment

Choose a reason for hiding this comment

Uh oh!

sumitd94 commented Apr 18, 2021

Uh oh!

swarajpure commented Apr 18, 2021

Uh oh!

akankshadharkar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akankshadharkar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

takshch left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swarajpure left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

swarajpure Jun 21, 2021

Choose a reason for hiding this comment

Uh oh!

sumitd94 Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

swarajpure Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

sumitd94 Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

takshch Jul 7, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swarajpure Aug 8, 2021

Choose a reason for hiding this comment

Uh oh!

sumitd94 commented Sep 6, 2021

Uh oh!

Reviewers

Assignees

sumitd94 commented Apr 9, 2021 •

edited

Loading

takshch left a comment •

edited

Loading