Skip to content

refactor(wait_for_status): Use self.instance to get status #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 4 commits into from
Aug 16, 2025
Merged

refactor(wait_for_status): Use self.instance to get status #2499

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7ddd30
refactor(wait_for_status): Use self.instance to get status
myakove Aug 13, 2025
75501ae
Merge branch 'main' of github.com:RedHatQE/openshift-python-wrapper i…
myakove Aug 14, 2025
bc36a78
refactor(wait_for_status): Use self.exists to get instance
myakove Aug 14, 2025
f19a6fa
Merge branch 'main' of github.com:RedHatQE/openshift-python-wrapper i…
myakove Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions ocp_resources/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,27 +971,25 @@ def wait_for_status(
**PROTOCOL_ERROR_EXCEPTION_DICT,
**DEFAULT_CLUSTER_RETRY_EXCEPTIONS,
},
func=self.api.get,
field_selector=f"metadata.name=={self.name}",
namespace=self.namespace,
func=lambda: self.exists,
Comment thread
dbasunag marked this conversation as resolved.
)
current_status = None
last_logged_status = None
try:
for sample in samples:
if sample.items:
sample_status = sample.items[0].status
if sample_status:
current_status = sample_status.phase
if current_status != last_logged_status:
last_logged_status = current_status
self.logger.info(f"Status of {self.kind} {self.name} is {current_status}")

if current_status == status:
return

if current_status == stop_status:
raise TimeoutExpiredError(f"Status of {self.kind} {self.name} is {current_status}")
if sample:
instance_dict = sample.to_dict()
current_status = instance_dict.get("status", {}).get("phase")

if current_status != last_logged_status:
last_logged_status = current_status
self.logger.info(f"Status of {self.kind} {self.name} is {current_status}")

if current_status == status:
return

if current_status == stop_status:
raise TimeoutExpiredError(f"Status of {self.kind} {self.name} is {current_status}")

except TimeoutExpiredError:
if current_status:
Expand Down